chore: Datadog PoC [OTE-702] [2/n] #932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
yogurtandjam
force-pushed
the
jerms/OTE-702_datadog-poc-2
branch
2 times, most recently
from
71acfe7
to
fb208b2
Compare
yogurtandjam
force-pushed
the
jerms/OTE-702_datadog-poc
branch
from
6ba0b21
to
b0db1e7
Compare
yogurtandjam
force-pushed
the
jerms/OTE-702_datadog-poc-2
branch
from
fb208b2
to
d82cfb5
Compare
yogurtandjam
changed the title
yogurtandjam
commented
Aug 19, 2024
src/lib/abacus/logger.ts
Outdated
| @@ -19,6 +21,20 @@ class AbacusLogger implements Omit<AbacusLoggingProtocol, '__doNotUseOrImplement | |||
| console.error(`${tag}: ${message}`); | |||
| } | |||
| } | |||
|
|
|||
| ddInfo(message: string, context: object) { | |||
There was a problem hiding this comment.
@dydxprotocol/frontend this is how im planning on giving abacus the power to log info and error msgs to datadog.
it's a little hacky but until we're ready to merge their logs i figure this is good enough.
yogurtandjam
changed the title
yogurtandjam
changed the title
yogurtandjam
changed the title
rosepuppy
reviewed
Aug 19, 2024
src/lib/analytics/amplitude.ts
Outdated
| @@ -22,7 +22,7 @@ export const identify = (property: AnalyticsUserProperty) => { | |||
| detail: { property: propertyTypeToLog, propertyValue: property.payload }, | |||
| }); | |||
| dd.setContextProperty(propertyTypeToLog, property.payload); | |||
| dd.log(`set context item: ${propertyTypeToLog}`, dd.getContext()); | |||
| dd.info(`set context item: ${propertyTypeToLog}`, dd.getContext()); | |||
There was a problem hiding this comment.
Does it make sense to just add dd.info to track? or was it decided that is too much events
There was a problem hiding this comment.
this was discussed in slack but we decided to be very conservative about the # of events we send and track the volume first
yogurtandjam
force-pushed
the
jerms/OTE-702_datadog-poc-2
branch
from
a053085
to
5ca2cf7
Compare
yogurtandjam
commented
Aug 20, 2024
yogurtandjam
force-pushed
the
jerms/OTE-702_datadog-poc
branch
2 times, most recently
from
50262b2
to
a2a3c4d
Compare
yogurtandjam
force-pushed
the
jerms/OTE-702_datadog-poc-2
branch
from
25d31ca
to
e0b5ffd
Compare
yogurtandjam
force-pushed
the
jerms/OTE-702_datadog-poc-2
branch
from
e0b5ffd
to
916fd06
Compare
add dd file revert usecompliancestate hook fix import names fix last broken import filepath add events to deposit and withdraw forms fix import names dydx chain transactions logs. add abacus logger implementation. auto log errors finish logger implementation add service name and env fix logging fix type typo
yogurtandjam
force-pushed
the
jerms/OTE-702_datadog-poc-2
branch
from
3ff9137
to
a21f598
Compare
yogurtandjam
force-pushed
the
jerms/OTE-702_datadog-poc-2
branch
from
4c79cb9
to
6e2a0d5
Compare
tinaszheng
reviewed
Sep 16, 2024
src/lib/abacus/logger.ts
Outdated
| dd.info(message, parsedContext); | ||
| // catch in case parsing context fails for some reason | ||
| } catch (err) { | ||
| dd.error('Error sending dd info', undefined, err); |
There was a problem hiding this comment.
maybe send the context string in this case?
There was a problem hiding this comment.
ah good point, forgot the error won't have that data. i like it
tinaszheng
approved these changes
Sep 16, 2024
tinaszheng
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds initial events described by the tech spec
Also adds ddInfo and ddError methods to abacus logger implementation so we can pick them up in abacus and use them at will.
Finally, this PR adds
dd.errorto thelogmethod, so any telemetry logs will automatically be piped into datadog