chore: bump abacus for min isolated margin validation #963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jaredvu
reviewed
Aug 28, 2024
Comment on lines
+403
to
+405
| a { | ||
| margin-left: 0.5ch; | ||
| } |
There was a problem hiding this comment.
if the a is inlined in the <span> I think we can just change display: inline-block so it respects spaces
There was a problem hiding this comment.
ooh good point - will follow up as a part of this for the sake of not having to reapprove!
jaredvu
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for dydxprotocol/v4-abacus#601
also add in logic to read in
linkandlinkTextreturned by abacus errors.