chore: prepush commit signing #990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jaredvu
reviewed
Sep 9, 2024
There was a problem hiding this comment.
is there a way to check at the pre-commit? I think this pre-push script is a good idea so they can go back and reconcile, but it would be ideal to know before even committing.
There was a problem hiding this comment.
@jaredvu i'm not 100% sure how that would work - in a pre-commit hook, the commit isn't created yet so idk if we can reliably tell if it's signed. we can check if commit signing is enabled but i'm not sure how reliable that would be
jaredvu
approved these changes
Sep 9, 2024
rosepuppy
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sometimes, rarely, commits sneak into PR's unsigned. this is annoying https://dydx-team.slack.com/archives/C06S9ND5T40/p1725897065808209
quick script to prevent this from happening