Console compiler: exit with error status for serious warnings #1439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why not add a command-line option to suppress this new exit status behavior, which could then be used when building libraries that deliberately induce serious warnings (such as the common-dylan-test-suite)? |
|
I was planning to add that flag in a later commit (please comment on the bug if you have preferences for what it should look like). I would like to be able to detect new serious warnings in the test suite and Open Dylan code, which is why I prefer to comment out those two tests. I could make the exit code be the total number of serious warnings (maxing out at 127, I guess, if that's a shell limitation...127 should be enough serious warnings for anyone) and then callers who expect non-zero could compare with that? |
Some could be removed by fooling the compiler. Commented out a couple for now. Perhaps we can reinstate test-ignorable and test-ignore when/if we have a way to disable compiler warnings for a swath of code.
Non-serious warnings do not cause an error exit status. We can enable that behavior later with a flag if desired. Issue dylan-lang#1373
cgay
force-pushed
the
exit-status
branch
2 times, most recently
from
1921d8d to
761cffa
Compare
This flag is added to the main command (i.e., the dylan-compiler and dylan-environment commands) but not to the interactive "build" command, since it serves no purpose in the interactive environment. The default value of this flag is off, which is an incompatible change.
housel
approved these changes
Sep 18, 2022
Don't use -1 since that is turned into 255 on unix systems. Small non-negative integers should work on all platforms. 0 = success 1 = unexpected error 2 = usage error 3 = serious warnings (controlled by flag)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Console compiler: exit with error status for serious warnings
Issue #1373