channels-test-suite cleanups #1476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also renamed to channels-test-suite to match standard naming scheme. The changes made to the Windows Makefile are untested. Also I don't believe these tests are run on windows because it assumes that channels-tests is an application, but in fact it never calls run-test-application. I didn't try to fix that since I wouldn't be able to verify it.
This must've been using a very old idea of how Testworks works. The `name:` and `description:` keywords do nothing in `define test` nowadays, so I removed them and made the test names themselves more descriptive. Reformatted local methods to be on multiple lines while here.
housel
approved these changes
Jan 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.