Fix source locations for multi-line raw strings #1491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Primarily removes the inlining/duplication of the maybe-done local method, but also makes a few other formatting changes to make more of this giant function fit on screen at one time. This commit makes no functional changes.
Fixes source locations for multi-line raw strings and multi-line quoted symbols. Tested by hand before and after three stage bootstraps.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...and multi-line quoted symbols.
We could simply always count newlines in tokens and remove the hackish check for one of the multi-line token creation functions, but it seemed like it could cause a noticeable slowdown.