Simplify testworks specs #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
housel
approved these changes
Nov 27, 2019
Previously, the function-test, class-test, macro-test, variable-test and constant-test macros generated functions that were accumulated and then executed with with-test-unit. This turns them into normal tests that are executed via the generated test suite.
This removes the tracking of definitions and bindings in favor of just immediately generating the appropriate tests to check the specifications. This removes the remaining usages of with-test-unit.
This is no longer used.
These are often not implemented, so this makes reports more useful.
This wasn't necessary and was just extra boilerplate. It also lets me give the tests better names more readily.
This re-organizes some of the macros to try to make the intent more clear and to separate module-spec and protocol-spec definers to call into the same underlying macros. This also brings back support for a module-spec referencing a protocol-spec and having that work. (This is used in the DUIM tests and probably others.)
No reason for these to be separate libraries. Also combined all of specs into one file, because it's easier to navigate the code that way.
* Removed the `define {variable,function,macro,constant,etc}-test` macros since
they are just a more verbose and more difficult to remember way to write
`define test`.
* Removed `define library-spec` and `define module-spec`, both of which are
trivially replaced with `define suite`. `define protocol-spec` is replaced
by `define interface-specification-suite` which should be given a normal test
suite name. The latter does one thing: performs automatic checks for an
API. It does not generate suites that expect one test per definition to be
written by the user. It's up to the user how they organize their test suite.
* Removed the `generic-function` spec, which was apparently redundant with the
`generic function` (with a space) spec. Maybe this was necessary due to an
old fixed bug?
* Removed class-test-function interface (just write normal tests)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second try. I think this is ready now, but it's big so it's possible I've missed something that needed polishing.
Rendered doc is here: http://50.116.53.62:8000/index.html