-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Conversation
Termite is in your list twice. |
Thanks, the 2nd termite was supposed to be iTerm2. :) |
Testing iTerm2 and Terminal.app now |
Font output won't work on them just yet but terminal detection should. |
Alright. What do you think will be needed for tmux support? I just set it up today :/ |
The terminal detection works by finding the parent process id of the current shell. This might work on OS X and other systems however and I just pushed a commit |
On iTerm2, it doesn't work at all, nothing is printed for On Terminal.app, |
Is this inside or outside of tmux? |
Outside |
We can workaround the OS X detection, iTerm2 has an envar and I'm sure |
@iandrewt, what's the value of |
…font specially if it merges an updated upstream into a topic branch.
|
Sweet! Once I'm at uni I'll add support for it. |
@iandrewt, can you test out the PR? OS X terminal detection should work now. |
Working for me in |
Awesome! Now we just need to add config file parsing for the OS X terminals. |
…ttle weirdly causing issues for some ascii art
Not every urxvt user has his colors in |
That's a good idea, thanks. |
added apple terminal font support
I want to get this merged soon, can anyone lurking here please test the PR Here's how you can test:
Thanks :) |
Weird that there's a hm |
@dawidd6, the issue should be fixed now. Please try it again when you have some time. :) |
Now it's just right 👍 |
This PR introduces two new functions,
term
- Get the current terminal emulator.termfont
- Get the terminal font.This closes #251.
TODO
termfont
support for popular terminal emulators.Regular Configs:
Profile Based Configs:
We need to figure out how to get the font on a per profile basis.
No Configs:
Font support can't be added as these terminals are configured at compile time.
Issues
term
doesn't work when run from inside a tmux session.$PPID
oftmux
issystemd
for some odd reason.term
doesn't work on Windows.ps
command is missing the-o
flag.Testing this PR
To test this PR just checkout this branch and run neofetch with
neofetch --config off
.