Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: cache system #77

Merged
merged 2 commits into from
May 25, 2023
Merged

refactor: cache system #77

merged 2 commits into from
May 25, 2023

Conversation

dylandoamaral
Copy link
Owner

@Anrolosia maybe you will find the PR interesting, don't hesitate if you see something weird.

@Anrolosia
Copy link
Contributor

I like the way you refactored it @dylandoamaral ! Great job.
But 1 hour is too much in my opinion, this is why originally it was 5 minutes. IMO if a user check a TV show or whatever, waiting for 5 minutes is acceptable but 1h seems a bit too long. What do you think?

@dylandoamaral dylandoamaral merged commit a9ff62d into main May 25, 2023
@dylandoamaral dylandoamaral deleted the refactor/cache-system branch May 25, 2023 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dylandoamaral @Anrolosia