Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Causal dmlestimator #8

Merged
merged 20 commits into from
Nov 12, 2022
Merged

Conversation

dylanw-oss
Copy link
Owner

Related Issues/PRs

#xxx

What changes are proposed in this pull request?

Briefly describe the changes included in this Pull Request.

How is this patch tested?

  • I have written tests (not required for typo or doc fix) and confirmed the proposed feature/bug-fix/change works.

Does this PR change any dependencies?

  • No. You can skip this section.
  • Yes. Make sure the dependencies are resolved correctly, and list changes here.

Does this PR add a new feature? If so, have you added samples on website?

  • No. You can skip this section.
  • Yes. Make sure you have added samples following below steps.
  1. Find the corresponding markdown file for your new feature in website/docs/documentation folder.
    Make sure you choose the correct class estimators/transformers and namespace.
  2. Follow the pattern in markdown file and add another section for your new API, including pyspark, scala (and .NET potentially) samples.
  3. Make sure the DocTable points to correct API link.
  4. Navigate to website folder, and run yarn run start to make sure the website renders correctly.
  5. Don't forget to add <!--pytest-codeblocks:cont--> before each python code blocks to enable auto-tests for python samples.
  6. Make sure the WebsiteSamplesTests job pass in the pipeline.

@github-actions
Copy link

Hey @dylanw-oss 👋!
Thank you so much for contributing to our repository 🙌.
Someone from SynapseML Team will be reviewing this pull request soon.

We use semantic commit messages to streamline the release process.
Before your pull request can be merged, you should make sure your first commit and PR title start with a semantic prefix.
This helps us to create release messages and credit you for your hard work!

Examples of commit messages with semantic prefixes:

  • fix: Fix LightGBM crashes with empty partitions
  • feat: Make HTTP on Spark back-offs configurable
  • docs: Update Spark Serving usage
  • build: Add codecov support
  • perf: improve LightGBM memory usage
  • refactor: make python code generation rely on classes
  • style: Remove nulls from CNTKModel
  • test: Add test coverage for CNTKModel

To test your commit locally, please follow our guild on building from source.
Check out the developer guide for additional guidance on testing your change.

@dylanw-oss dylanw-oss changed the title Causal dmlestimator feat: Causal dmlestimator Nov 12, 2022
@dylanw-oss dylanw-oss merged commit 08c79cc into linearDMLEstimator Nov 12, 2022
dylanw-oss added a commit that referenced this pull request Jan 3, 2023
* feat: Causal dmlestimator (#8)

Add package 'com.microsoft.azure.synapse.ml.causal' and implementation LinearDMLEstimator

* resolve comments and fix build pipeline failures

* add //scalastyle:off method.length for trainIternal

* fix DML Python API missing problem

* fix build pipeline failures

* rename LinearDMLEstimator to DoubleMLEstimator

* rename DML APIs

* forgot to change DoubleMLModel name in fuzzingTest

* use findUnusedColumnName for treatmentResidual and outcomeResidul comlumns

* address a few small comments

* remove HasExcludeFeatureCols and use HasInputCols

* fix style issue, Params.scala: File must end with newline character

* set DoubleMLEstimator transform as experimental

Co-authored-by: Jason Wang <jasowang@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant