fix(iro): missing StartTimeAfterSettlement in IRO default params (#…

…1704) * fixed missing StartTimeAfterSettlement in incentives params * linter
dymensionxyz · Jan 8, 2025 · 10edf97 · 10edf97
1 parent 4ebef89
commit 10edf97
Show file tree

Hide file tree

Showing 3 changed files with 25 additions and 1 deletion.
diff --git a/x/iro/types/plan.go b/x/iro/types/plan.go
@@ -94,7 +94,8 @@ func (p Plan) GetIRODenom() string {
 
 func DefaultIncentivePlanParams() IncentivePlanParams {
 	return IncentivePlanParams{
-		NumEpochsPaidOver: 43200, // 1 month in minute epoch
+		NumEpochsPaidOver:        43200, // 1 month in minute epoch
+		StartTimeAfterSettlement: DefaultIncentivePlanMinimumStartTimeAfterSettlement,
 	}
 }
 

diff --git a/x/rollapp/keeper/msg_server_update_rollapp_test.go b/x/rollapp/keeper/msg_server_update_rollapp_test.go
@@ -389,6 +389,16 @@ func (s *RollappTestSuite) TestUpdateRollappLaunched() {
 			},
 			expError: types.ErrImmutableFieldUpdateAfterLaunched,
 		},
+		// update min sequencer bond
+		{
+			name: "Update sealed rollapp: fail - min sequencer bond update",
+			update: &types.MsgUpdateRollappInformation{
+				Owner:            alice,
+				RollappId:        rollappId,
+				MinSequencerBond: types.DefaultMinSequencerBondGlobalCoin,
+			},
+			expError: types.ErrImmutableFieldUpdateAfterLaunched,
+		},
 		{
 			name: "Update sealed rollapp: fail - try to update genesis checksum when sealed",
 			update: &types.MsgUpdateRollappInformation{
@@ -401,6 +411,17 @@ func (s *RollappTestSuite) TestUpdateRollappLaunched() {
 			},
 			expError: types.ErrImmutableFieldUpdateAfterLaunched,
 		},
+		// TODO: should return error, but now it doesn't (https://github.com/dymensionxyz/dymension/issues/1703)
+		{
+			name: "Update rollapp: success - set non valid min denom ignores this field",
+			update: &types.MsgUpdateRollappInformation{
+				Owner:            alice,
+				RollappId:        rollappId,
+				MinSequencerBond: sdk.Coin{Denom: "no_valid_1243", Amount: sdk.NewInt(100)},
+			},
+			mallete:  func(expected *types.Rollapp) {},
+			expError: nil,
+		},
 	}
 
 	for _, tc := range tests {

diff --git a/x/rollapp/types/message_update_rollapp.go b/x/rollapp/types/message_update_rollapp.go
@@ -71,6 +71,8 @@ func (msg *MsgUpdateRollappInformation) ValidateBasic() error {
 		}
 	}
 
+	// TODO: validate min seq bond (https://github.com/dymensionxyz/dymension/issues/1703)
+
 	if msg.Metadata != nil {
 		if err := msg.Metadata.Validate(); err != nil {
 			return errors.Join(ErrInvalidMetadata, err)