Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(migrations): renamed vulnerable rollapps to obsolete #1436

Merged
merged 3 commits into from
Nov 8, 2024
Merged

feat(migrations): renamed vulnerable rollapps to obsolete #1436

merged 3 commits into from
Nov 8, 2024

Conversation

keruch
Copy link
Contributor

@keruch keruch commented Nov 8, 2024 •
edited
Loading

Description

Closes #1413

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow-up issues.

PR review checkboxes:

I have...

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Targeted PR against the correct branch
  • included the correct type prefix in the PR title
  • Linked to the GitHub issue with discussion and accepted design
  • Targets only one GitHub issue
  • Wrote unit and integration tests
  • Wrote relevant migration scripts if necessary
  • All CI checks have passed
  • Added relevant godoc comments
  • Updated the scripts for local run, e.g genesis_config_commands.sh if the PR changes parameters
  • Add an issue in the e2e-tests repo if necessary

SDK Checklist

  • Import/Export Genesis
  • Registered Invariants
  • Registered Events
  • Updated openapi.yaml
  • No usage of go map
  • No usage of time.Now()
  • Used fixed point arithmetic and not float arithmetic
  • Avoid panicking in Begin/End block as much as possible
  • No unexpected math Overflow
  • Used sendCoin and not SendCoins
  • Out-of-block compute is bounded
  • No serialized ID at the end of store keys
  • UInt to byte conversion should use BigEndian

Full security checklist here

For Reviewer:

  • Confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • Confirmed all author checklist items have been addressed

After reviewer approval:

  • In case the PR targets the main branch, PR should not be squash merge in order to keep meaningful git history.
  • In case the PR targets a release branch, PR must be rebased.

@keruch keruch self-assigned this Nov 8, 2024
@keruch keruch requested a review from a team as a code owner November 8, 2024 08:04
@keruch keruch changed the title Kirill/1413 obsolete rollapps 1 feat(migrations): renamed vulnerable rollapps to obsolete Nov 8, 2024
@keruch keruch requested review from omritoptix and danwt November 8, 2024 08:06
@danwt danwt merged commit 47be8d3 into mtsitrin/937-rollapp-hard-fork-hub-side Nov 8, 2024
5 checks passed
@danwt danwt deleted the kirill/1413-obsolete-rollapps-1 branch November 8, 2024 10:03
mtsitrin added a commit that referenced this pull request Jan 13, 2025
@mtsitrin @keruch
@zale144 @danwt @omritoptix @srene @ItzhakBokris
refactor(lightclient): removed the need for next stateInfo for valiad…
200dd62 
…ition (#1467)

* initial renames according to adr

* reverting states

* removed frozen notation. added revision number in rollapp object

* cleanup

* UT compiles

* fixed state deletion on fraud

* UT pass

* fixed StateInfoByHeight UT

* chainId revision check moved back to create rollapp. as it mess up dymns UT

* PR comments

* fixed basic sequencer logic to unbond all

* feat(hard_fork): part2 (Delyayed ack callback) (#1355)

* feat(hard_fork): Lightclient rollback (#1363)

* feat(hard_fork): DRS and stateUpdate (#1369)

* feat(hard_fork): rollapp fraud proposal (#1371)

* feat(hard_fork): revision start height (#1373)

* cleanup

* lightClient doesn't trigger hard fork

* clearing consesnsus state in descending order

* fix UT

* fraud proposal validates genesis bridge completed

* validate revision in header.Header.Version.App

* linter

* linter

* feat(hard_fork): delayed ack should create commitment after rolling back acks (#1383)

* register proposal handler

* updating next proposer on state infos

* feat(hard_fork): update hard fork to support new `x/sequencer` updates (#1406)

Co-authored-by: keruch <53012408+keruch@users.noreply.github.com>
Co-authored-by: zale144 <aleksandar.sukovic@gmail.com>
Co-authored-by: Daniel T <30197399+danwt@users.noreply.github.com>
Co-authored-by: Omri <omritoptix@gmail.com>
Co-authored-by: Sergi Rene <sergi@dymension.xyz>
Co-authored-by: Itzhak Bokris <jzak300@gmail.com>

* linter

* UT fix

* minor update to fraud proposal

* delete pendingPacketsByAddress on the delayedAck

* fixed seqeucner heoght pruning

* fraud proposal supports future heights

* fork hook doesn't return error

* rotation doesn't go through sentinel proposer

* simplified k.UpdateRollappPacketWithStatus interface

* minor

* minor log

* fixed lightclient when setting canonical channel

* feat(migrations): renamed vulnerable rollapps to obsolete (#1436)

* Danwt/mtsitrin 937 rollapp hard fork hub side rewardee (#1441)

* Danwt/fix upgrade conflicts (#1442)

Co-authored-by: zale144 <aleksandar.sukovic@gmail.com>
Co-authored-by: keruch <53012408+keruch@users.noreply.github.com>

* fix frozen

* refactored to use Finalaization queue by rollappId

* fixed pruning of finalization queue

* cleared unused expected methods

* linter

* more cleanup

* comments

* fixed packet commitment and lightclient comments

* return err on HardFork hooks

* not forking on state update with obsolete DRS

* linter

* renamed fraudHeight

* add error to kickProposer flow

* fixed UT

* deleteBySender moved to DeletePacket

* fixed surprise linter

* DRY pruneSigners code

* feat(sequencer): hardforking when rotating to sentinel (#1455)

Co-authored-by: danwt <30197399+danwt@users.noreply.github.com>

* PR comments

* AfterRecoveryFromHalt hook cleanup

* fixed missing setConsensusMetadata. fixed kicked proposer unbond

* fixed unbond store

* refactor ValidateUpdatePessimistically to use single state info

refactor canonical client check

* updated expected keeper

* dried out the state update hook

* removed unused replace

* unified canonical and ongoingvalidation

* fix future height check

* DRY canonical setting code

* revert renaming

* removed canonical setting on update headers

* fixed tests compile

---------

Co-authored-by: keruch <53012408+keruch@users.noreply.github.com>
Co-authored-by: zale144 <aleksandar.sukovic@gmail.com>
Co-authored-by: Daniel T <30197399+danwt@users.noreply.github.com>
Co-authored-by: Omri <omritoptix@gmail.com>
Co-authored-by: Sergi Rene <sergi@dymension.xyz>
Co-authored-by: Itzhak Bokris <jzak300@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omritoptix omritoptix Awaiting requested review from omritoptix

@danwt danwt Awaiting requested review from danwt

Assignees

@keruch keruch

Labels
dym-internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@keruch @danwt