Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do you really require @dev constraints? #110

Closed
chillu opened this issue Mar 17, 2019 · 5 comments
Closed

Do you really require @dev constraints? #110

chillu opened this issue Mar 17, 2019 · 5 comments
Milestone

Comments

@chillu
Copy link

chillu commented Mar 17, 2019

Looking at the composer.json, there's a lot of @dev. Which breaks anyone trying to use those stable module tags (e.g. 3.0.0) with stable core dependencies (like cms:4.3.2@stable). If you're actually relying on unreleased versions of those dependencies, it might be a good idea to hold off tagging your own stable releases? In the more likely case that you're not relying on it, could you please remove the @dev and tag that as 3.0.1?

@muskie9
Copy link
Member

muskie9 commented Mar 19, 2019

Thanks for the suggestion @chillu, I don't know that there's a good reason outside of the upgrade transition period while we were getting everything working with SilverStripe 4. I'll confirm with the team and we'll get updated releases where needed.

@chillu
Copy link
Author

chillu commented Mar 19, 2019

Awesome, thanks Nic! I realised that's the case for a lot of the other (super awesome) blocks modules in dynamic as well. By the way, I've used some of your modules in a sales pitch yesterday, great to be able to wow people with community-built features!

This was referenced Mar 20, 2019
@mak001
Copy link
Contributor

mak001 commented Mar 20, 2019

We should also check for PHPUnit in composer instead of phpunit as the former throws warnings.

muskie9 added a commit to muskie9/silverstripe-elemental-blocks that referenced this issue Mar 20, 2019
- Update `phpunit/PHPUnit` to `phpunit/phpunit`
- Remove reference to `silverstripe/recipe-cms` as this should be handled by `dnadesign/silverstripe-elemental`
- Remove reference to `dnadesign/silverstripe-elemental` as this should be handled by elements pulled in by this recipe

resolves dynamic#110
@muskie9 muskie9 added this to the 3.0.1 milestone Mar 20, 2019
@muskie9
Copy link
Member

muskie9 commented Mar 21, 2019

@chillu we've gone through our elemental modules and have resolved the dev constraint. Let us know if you come across any issues with the latest tags.

@muskie9 muskie9 closed this as completed Mar 21, 2019
@chillu
Copy link
Author

chillu commented Mar 21, 2019

Wow, so many PRs! Thanks heaps :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants