-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do you really require @dev constraints? #110
Comments
Thanks for the suggestion @chillu, I don't know that there's a good reason outside of the upgrade transition period while we were getting everything working with SilverStripe 4. I'll confirm with the team and we'll get updated releases where needed. |
Awesome, thanks Nic! I realised that's the case for a lot of the other (super awesome) blocks modules in |
We should also check for |
- Update `phpunit/PHPUnit` to `phpunit/phpunit` - Remove reference to `silverstripe/recipe-cms` as this should be handled by `dnadesign/silverstripe-elemental` - Remove reference to `dnadesign/silverstripe-elemental` as this should be handled by elements pulled in by this recipe resolves dynamic#110
@chillu we've gone through our elemental modules and have resolved the dev constraint. Let us know if you come across any issues with the latest tags. |
Wow, so many PRs! Thanks heaps :) |
Looking at the
composer.json
, there's a lot of@dev
. Which breaks anyone trying to use those stable module tags (e.g.3.0.0
) with stable core dependencies (likecms:4.3.2@stable
). If you're actually relying on unreleased versions of those dependencies, it might be a good idea to hold off tagging your own stable releases? In the more likely case that you're not relying on it, could you please remove the@dev
and tag that as3.0.1
?The text was updated successfully, but these errors were encountered: