Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change carousel class #139

Closed
korthjp17 opened this issue Mar 23, 2018 · 0 comments
Closed

change carousel class #139

korthjp17 opened this issue Mar 23, 2018 · 0 comments
Assignees
@muskie9 @jsirish @mak001 @korthjp17
Labels
bug enhancement
Milestone
4.0.0

Comments

@korthjp17
Copy link
Contributor

This is a pretty generic class name for the thumbnail navigation. I've noticed some conflicts recently with other carousel plugins that use the same class. Wondering if we should use .fs-carousel or something a little more specific to FlexSlider.

We'll also have to update any default styling to reflect this change for the new carousel class.
@muskie9 muskie9 added this to the 4.0.0 milestone May 8, 2019
muskie9 added a commit to muskie9/SilverStripe-FlexSlider that referenced this issue May 17, 2019
@muskie9
REFACTOR update carousel class to fs-carousel
f639708 
resolves dynamic#139
@muskie9 muskie9 mentioned this issue May 17, 2019
Merged
muskie9 added a commit to muskie9/SilverStripe-FlexSlider that referenced this issue May 23, 2019
@muskie9
REFACTOR update carousel class to fs-carousel
f3562a0 
resolves dynamic#139
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@muskie9 muskie9

@jsirish jsirish

@mak001 mak001

@korthjp17 korthjp17

Labels
bug enhancement
Projects
None yet
Milestone
4.0.0
Development

No branches or pull requests
4 participants
@muskie9 @jsirish @mak001 @korthjp17