Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default template to use includes rather than $Me #183

Closed
korthjp17 opened this issue May 30, 2019 · 0 comments · Fixed by #205
Closed

Change default template to use includes rather than $Me #183

korthjp17 opened this issue May 30, 2019 · 0 comments · Fixed by #205
Assignees
Milestone

Comments

@korthjp17
Copy link
Contributor

This will allow for a bit more flexibility so you can spec the full namespace to the include.

We will keep the files in the Model section for now in case someone is still using the $Me in their templates.

Rather than use $Me, lets try this:

<% if $SlideType == Image %>
  <% include Dynamic\\FlexSlider\\Includes\\SlideImage_Image %>
<% else_if $SlideType == Video %>
  <% include Dynamic\\FlexSlider\\Includes\\SlideImage_Video %>
<% else_if $SlideType == Text %>
  <% include Dynamic\\FlexSlider\\Includes\\SlideImage_Text %>
<% end_if %>
@korthjp17 korthjp17 added this to the 4.1.0 milestone May 30, 2019
@korthjp17 korthjp17 self-assigned this May 30, 2019
@muskie9 muskie9 added the v4 label May 30, 2019
jsirish added a commit to jsirish/silverstripe-flexslider that referenced this issue Jun 2, 2019
ping dynamic#183

moving the path seems to fix the error. Did not implement the if checks due to missing includes
jsirish added a commit to jsirish/silverstripe-flexslider that referenced this issue Jun 3, 2019
@muskie9 muskie9 modified the milestones: 4.1.0, 5.0.0 Jan 15, 2020
korthjp17 added a commit to korthjp17/SilverStripe-FlexSlider that referenced this issue May 26, 2021
jsirish pushed a commit to korthjp17/SilverStripe-FlexSlider that referenced this issue May 26, 2021
jsirish pushed a commit that referenced this issue May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants