Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SlideImage - refactor CMSFields #103

Merged
merged 1 commit into from
Mar 14, 2017

Conversation

jsirish
Copy link
Member

@jsirish jsirish commented Mar 10, 2017

allow for ease of extendability

closes #100

ping #98

allow for ease of extendability

closes dynamic#100

ping dynamic#98
@codecov
Copy link

codecov bot commented Mar 10, 2017

Codecov Report

Merging #103 into 1.0 will increase coverage by 0.2%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##              1.0     #103     +/-   ##
=========================================
+ Coverage   69.65%   69.86%   +0.2%     
=========================================
  Files           2        2             
  Lines         145      146      +1     
=========================================
+ Hits          101      102      +1     
  Misses         44       44
Impacted Files Coverage Δ
code/SlideImage.php 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df4d0ff...3d3f193. Read the comment docs.

@jsirish jsirish requested a review from muskie9 March 13, 2017 20:28
Copy link
Member

@muskie9 muskie9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@muskie9 muskie9 merged commit 4e753fc into dynamic:1.0 Mar 14, 2017
@jsirish jsirish deleted the refactor/slideImageFieldRefactor branch June 3, 2019 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants