Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated to be a vendor module #129

Merged
merged 1 commit into from
Nov 1, 2017
Merged

Updated to be a vendor module #129

merged 1 commit into from
Nov 1, 2017

Conversation

mak001
Copy link
Contributor

@mak001 mak001 commented Oct 30, 2017

No description provided.

@codecov
Copy link

codecov bot commented Oct 30, 2017 •
edited
Loading

Codecov Report

Merging #129 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #129   +/-   ##
=========================================
  Coverage     68.18%   68.18%           
  Complexity       25       25           
=========================================
  Files             2        2           
  Lines           110      110           
=========================================
  Hits             75       75           
  Misses           35       35

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 566f5d4...5d5ee87. Read the comment docs.

@mak001 mak001 requested review from jsirish and muskie9 November 1, 2017 14:21
jsirish
jsirish approved these changes Nov 1, 2017
View reviewed changes
Copy link
Member

@jsirish jsirish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

glad you zapped my "test" in the template 😆

@mak001 mak001 merged commit 5587cf8 into dynamic:master Nov 1, 2017
@mak001 mak001 deleted the vendor-module branch November 1, 2017 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsirish jsirish jsirish approved these changes

@muskie9 muskie9 Awaiting requested review from muskie9

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mak001 @jsirish