Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REFACTOR remove SlidePublishTask #176

Merged
merged 1 commit into from
May 23, 2019

Conversation

muskie9
Copy link
Member

@muskie9 muskie9 commented May 17, 2019

ping #166

This removes the legacy SlidePublishTask from v4 per discussion on #166

@muskie9 muskie9 added the v4 label May 17, 2019
@muskie9 muskie9 added this to the 4.0.0 milestone May 17, 2019
@muskie9 muskie9 requested a review from jsirish May 17, 2019 15:34
@codecov
Copy link

codecov bot commented May 17, 2019

Codecov Report

Merging #176 into master will increase coverage by 3.62%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #176      +/-   ##
============================================
+ Coverage     49.83%   53.45%   +3.62%     
+ Complexity       90       81       -9     
============================================
  Files             6        5       -1     
  Lines           295      275      -20     
============================================
  Hits            147      147              
+ Misses          148      128      -20
Impacted Files Coverage Δ Complexity Δ
src/Task/SlideLinkTask.php 0% <ø> (ø) 17 <0> (ø) ⬇️
src/Task/SlideThumbnailNavMigrationTask.php 0% <ø> (ø) 13 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0767afb...418f924. Read the comment docs.

@muskie9 muskie9 merged commit f7ca71e into dynamic:master May 23, 2019
@muskie9 muskie9 deleted the refactor/slidePublishTaskRemove#166 branch May 23, 2019 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant