Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up #63

Merged
merged 1 commit into from
Sep 15, 2016
Merged

Clean up #63

merged 1 commit into from
Sep 15, 2016

Conversation

jsirish
Copy link
Member

@jsirish jsirish commented Sep 15, 2016

  • SlideImage - moved statics from config.yml to class
  • FlexSlider - added requirements to contentcontrollerInit()
  • FlexSliderExtension - removed requirements, left empty for backwards compatability

@codecov-io
Copy link

codecov-io commented Sep 15, 2016 •
edited
Loading

Current coverage is 73.04% (diff: 23.52%)

Merging #63 into 1.0 will decrease coverage by 20.78%

@@                1.0        #63   diff @@
==========================================
  Files             2          2          
  Lines            81        115    +34   
  Methods          10         11     +1   
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits             76         84     +8   
- Misses            5         31    +26   
  Partials          0          0

Powered by Codecov. Last update 804d06e...12f6e5e

@jsirish
Clean up
12f6e5e 
* SlideImage - moved statics from config.yml to class

* FlexSlider - added requirements to `contentcontrollerInit()`

* FlexSliderExtension - added depreciation method as this file is no longer used

* updated README to remove references to `FlexSliderExtension`
@jsirish jsirish merged commit 6369dcc into dynamic:1.0 Sep 15, 2016
@jsirish jsirish deleted the feature/contentcontrollerInit branch September 15, 2016 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsirish @codecov-io