Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue #64 #65

Merged
merged 2 commits into from
Nov 11, 2022
Merged

Fix for issue #64 #65

merged 2 commits into from
Nov 11, 2022

Conversation

obj63mc
Copy link
Contributor

@obj63mc obj63mc commented Nov 11, 2022

Currently it looks like geocoder when looking at the raw result for coordinates may return the lat/longitude in random order. This method uses the geocoders default methods for getting the latitude and longitude which will then store the proper values.

Currently it looks like geocoder when looking at the raw result for coordinates may return the lat/longitude in random order.  This method uses the geocoders default methods for getting the latitude and longitude which will then store the proper values.
@jsirish
Copy link
Member

jsirish commented Nov 11, 2022

thanks @obj63mc ! Seems to work great, I'll merge it in and tag a release.

@codecov
Copy link

codecov bot commented Nov 11, 2022

Codecov Report

Base: 40.11% // Head: 40.85% // Increases project coverage by +0.73% 🎉

Coverage data is based on head (a2fec6b) compared to base (70a9296).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##                2.0      #65      +/-   ##
============================================
+ Coverage     40.11%   40.85%   +0.73%     
  Complexity       55       55              
============================================
  Files             4        4              
  Lines           167      164       -3     
============================================
  Hits             67       67              
+ Misses          100       97       -3     
Flag Coverage Δ
unittests 40.85% <0.00%> (+0.73%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/AddressDataExtension.php 58.26% <0.00%> (+0.99%) ⬆️
src/DistanceDataExtension.php 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants