Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.NET Framework 4.5.2 end of support is April 26, 2022 #224

Closed
metoule opened this issue Jan 31, 2022 · 3 comments · Fixed by #225
Closed

.NET Framework 4.5.2 end of support is April 26, 2022 #224

metoule opened this issue Jan 31, 2022 · 3 comments · Fixed by #225
Assignees
@davideicardi

Comments

@metoule
Copy link
Contributor

metoule commented Jan 31, 2022

DynamicExpresso is configured for multi-targeting:

<TargetFrameworks>netstandard2.0;net461;net45</TargetFrameworks>

.NET 4.5 is reaching end of support on April 26, 2022:

image

That means that the lowest supported version of .NET Framework is now .NET 4.6.2, which is compatible with netstandard2.0.

Therefore, I suggest the following:

  • only target netstandard2.0 in DynamicExpresso.Core
  • target netcoreapp5.0;netcoreapp3.1;net462 in DynamicExpresso.UnitTest
@metoule
Copy link
Contributor Author

metoule commented Jan 31, 2022

@davideicardi what do you think?

metoule added a commit to metoule/DynamicExpresso that referenced this issue Jan 31, 2022
@metoule
Change project target frameworks.
c4435a9 
Fix dynamicexpresso#224
@metoule metoule mentioned this issue Jan 31, 2022
Merged
@davideicardi
Copy link
Member

@metoule Fine for me! Good idea!

@metoule
Copy link
Contributor Author

metoule commented Feb 1, 2022

I think it will probably need a version bump to 3.0.0 though, because it's a breaking change.
If needed, here's a SO question to use .NET4.5 with VS2022.

metoule added a commit that referenced this issue Feb 9, 2022
@metoule
Change project target frameworks. (#225)
5b185e9 
Fix #224
metoule added a commit to metoule/DynamicExpresso that referenced this issue Mar 7, 2022
@metoule
Cleanup csproj after removing NET Framework support.
ddb3e61 
dynamicexpresso#224
metoule added a commit that referenced this issue Mar 9, 2022
@metoule
Cleanup csproj after removing support for .NET Framework (#230)
3fd3715 
Cleanup csproj after removing NET Framework support.
#224
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davideicardi davideicardi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change project target frameworks metoule/DynamicExpresso
2 participants
@davideicardi @metoule