Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Target framework 4.5.2 in 2.x versions #79

Closed
JobaDiniz opened this issue May 1, 2018 · 7 comments
Closed

Target framework 4.5.2 in 2.x versions #79

JobaDiniz opened this issue May 1, 2018 · 7 comments

Comments

@JobaDiniz
Copy link

Why the sudden drop support for framework 4.5.2? I cannot install the new nuget in the a project targeting 4.5.2.

Was this intended?

@davideicardi
Copy link
Member

Yes, I take the opportunity when converting to .net standard to also upgrade .net framework version.
I can probably also support .net 4.5, but I should check. For you is not possible to upgrade? Because nowdays there are a lot of packages that start to drop support for older frameworks.

Also note that for now v2 has only some bug fixes, there aren't new features, so you can also evaluate to continue to use v1.

@JobaDiniz
Copy link
Author

JobaDiniz commented May 2, 2018 via email

@davideicardi
Copy link
Member

Ok, I will try to add .net 4.5 support for the next release.

@davideicardi davideicardi added this to the 2.x milestone May 2, 2018
@moh-hassan
Copy link
Contributor

@davideicardi
I checked the package with Net45 and it's compiled without errors.
All test pass successfully in both net45 and netcoreapp2.0.

@davideicardi
Copy link
Member

@moh-hassan If you are able to create a pull request I will be happy to merge it. Thanks

@moh-hassan
Copy link
Contributor

moh-hassan commented Jan 15, 2019

PR is Done :).
Let me know for any help or support.
Check

@davideicardi
Copy link
Member

Fixed with #102

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants