Handle default parameters type explicitly #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an argument default value is gathered from a method definition be sure to pass also its associated argument when creating the Expression.Constant. This avoids a problem which happens when the argument is null: in this case the type of the argument will be System.Object and that will fail when binding the arguments a method defining a different type (for example string) In addition a new unit test was added to showcase this situation.
davideicardi
changed the title
|
Thanks @weltall , just merged! See v2.3.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an argument default value is gathered from a method definition be sure to pass also its associated argument when creating the Expression.Constant.
This avoids a problem which happens when the argument is null: in this case the type of the argument will be System.Object and that will fail when binding the arguments to a method defining a different type (for example string)
Additionally see remarks section from https://docs.microsoft.com/en-us/dotnet/api/system.linq.expressions.expression.constant?view=netframework-4.7.2#System_Linq_Expressions_Expression_Constant_System_Object_ )
In addition a new unit test was added to showcase this situation.