-
-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow explicit return type object #186
Conversation
…icitly object. Force the return type of a lambda expression to typeof(void) to prevent the emission of a conversion expresssion. Fixes dynamicexpresso#185
Thank you! I will look at this better in the following days. |
I agree that it's a bit wrong to use void in that case.. I considered a few alternatives that didn't feel great either:
In the end, since this is purely internal for when we parse a lambda expression, it seemed acceptable to use void to minimize the impact. If you have a better idea, I'm all for it :) |
@metoule If in some days I will not be able to complete it we can fallback to your solution, that in anycase looks like to be good. Ok? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you as usual!
No longer omit the conversion expression when the return type is explicitly object.
Force the return type of a lambda expression to
typeof(void)
to prevent the emission of a conversion expression.Fixes #185