Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue when parsing hexadecimal and binary literals #242

Merged
merged 1 commit into from
Jun 23, 2022
Merged

Fix issue when parsing hexadecimal and binary literals #242

merged 1 commit into from
Jun 23, 2022

Conversation

metoule
Copy link
Contributor

@metoule metoule commented Jun 22, 2022

The lexer took one more character than needed when parsing an hexadecimal or a binary literal:

4+0x124+5

Instead of 0x124, the lexer considered 0x124+ to be the literal. Now, we backtrack one character to avoid this issue.

Fix #241

davideicardi
davideicardi approved these changes Jun 23, 2022
View reviewed changes
Copy link
Member

@davideicardi davideicardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@metoule metoule merged commit 42132ad into dynamicexpresso:master Jun 23, 2022
@metoule metoule deleted the fix_241 branch June 23, 2022 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davideicardi davideicardi davideicardi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error when parsing hex number inside parenthesis
2 participants
@metoule @davideicardi