-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HuggingFace Refactor #154
base: main
Are you sure you want to change the base?
HuggingFace Refactor #154
Conversation
ludgerpaehler
commented
Mar 14, 2024
- Pushing geometries, checkpoints, and checkpoint out into dedicated HuggingFace data repositories.
- HydroGym Checkpoints
- HydroGym Meshes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great. Could you maybe add an example or note in the docs about how users can pull this data? Maybe people will be familiar with HF repos, but at least I didn't know about them.
And let's actually keep the .geo
files in the GH repo if that's okay with you. These are small and human readable, and it'd be nice to be able to see changes to mesh definitions easily. The other data is convenient but optional, since someone could rebuild it all themselves.
Tasks to completion:
|
The data-loading will be automatic, hidden away from the user. |
I'd rather not. Leaving them out in the dataset repo allows us to purge the os-dependency, which we shouldn't have. I'd rather load them directly through the dataset API.. |
Or we need to find a solution with the |
@jcallaham same is valid for the default configurations btw, will try to move them out to their own json configurations later today s.t. they are isolated and we don't carry values in the configuration code anymore. |
… lp/hf-refactor Merge in remote additions to the pyproject toml.
… only the name of the mesh.
WIP not merge-ready |
I'm good with that - when the built-in meshes can be pulled from HF we can get rid of the convenience of not having to specify the full path manually, which is all the Also if I wanted to rename the meshes away from the "coarse", "medium", "fine" towards something a little less misleading, is it too late to do that? |