-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] self.n_input_features_ AttributeError -- (PySINDy doesn't work with scikit-learn 1.0) #124
Comments
We are planning a new release shortly (a few weeks) with lots of new SINDy functionality. I will try to fix this for the new release. |
Fixed this in the new release. Hopefully will get this out in a few weeks. For future reference, the issue is that scikit-learn 1.0 and beyond has decided that self.n_inputs_features_ should be called self.n_features_in_ so the fix is we have to check the scikit-learn version whenever assigning this variable for now. |
Hi, I see that this bug is still present in the master branch - I've just cloned and tried the basic example of the guide triggering the bug. What about a quick fix by constraining the version of
in In any case, thank you for |
Hi Emanuele! Glad you're using the code. You're right that this is an easy fix but we are waiting for the new release (hopefully here by the end of the week) where we have fixed the bug and allow for scikit-learn version 1.0 and above as well. Keep an eye out for that :) |
Thank you for the very good news! |
The new release is out, with a fix to this bug, so closing this issue now. Let me know if you encounter any more scikit-learn issues. |
* Add issue templates drafts * Add default title * Update .github/ISSUE_TEMPLATE/bug_report.md Co-authored-by: Martin Gauch <15731649+gauchm@users.noreply.github.com> * Update bug_report.md Co-authored-by: Martin Gauch <15731649+gauchm@users.noreply.github.com>
Co-authored-by: Hamshaw, Scott Douglas <shamshaw@usgs.gov>
Hello,
Today I have updated scikit-learn to version 1.0 and it seems that Pysindy is not compatible with this version yet.
Any plans to upgrade PySINDy to support sklearn 1.0?
Thank you
The text was updated successfully, but these errors were encountered: