Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Commit

Permalink
fix(inline-editor): Remove deprecated aria-label input attributes.
Browse files Browse the repository at this point in the history
BREAKING CHANGE: Old attributes do not conform with accessibility standards.
  • Loading branch information
rowa-audil authored and ffriedl89 committed May 12, 2020
1 parent 8a0ceb0 commit 6be8f30
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 34 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
[required]="required"
[disabled]="saving"
[value]="value"
(keydown)="onKeyDown($event)"
(keydown)="_onKeyDown($event)"
(input)="_onInput($event)"
/>
</div>
Expand Down
33 changes: 0 additions & 33 deletions libs/barista-components/inline-editor/src/inline-editor.ts
Original file line number Diff line number Diff line change
Expand Up @@ -121,20 +121,6 @@ export class DtInlineEditor extends _DtInlineEditorMixinBase
this._required = coerceBooleanProperty(value);
}

/**
* Aria label of the inline-editor's save button.
* @deprecated `aria-label-save` does not conform with accessibility standards.
* Please use `ariaLabelSave` input instead.
* @breaking-change Will be removed in version 7.0.0
*/
@Input('aria-label-save')
get depAriaLabelSave(): string {
return this._ariaLabelSave;
}
set depAriaLabelSave(value: string) {
this._ariaLabelSave = value;
}

/** Aria label of the inline-editor's save button. */
@Input()
get ariaLabelSave(): string {
Expand All @@ -146,20 +132,6 @@ export class DtInlineEditor extends _DtInlineEditorMixinBase
/** @internal Aria label for the save button. */
_ariaLabelSave: string;

/**
* Aria label of the inline-editor's cancel button.
* @deprecated `aria-label-cancel` does not conform with accessibility standards.
* Please use `ariaLabelCancel` input instead.
* @breaking-change Will be removed in version 7.0.0
*/
@Input('aria-label-cancel')
get depAriaLabelCancel(): string {
return this._ariaLabelCancel;
}
set depAriaLabelCancel(value: string) {
this._ariaLabelCancel = value;
}

/** Aria label of the inline-editor's cancel button. */
@Input()
get ariaLabelCancel(): string {
Expand Down Expand Up @@ -306,11 +278,6 @@ export class DtInlineEditor extends _DtInlineEditorMixinBase
this._destroy$.complete();
}

/** @deprecated Will be removed in 6.0.0 */
onKeyDown(event: KeyboardEvent): void {
this._onKeyDown(event);
}

/** Enters the edit mode */
enterEditing(): void {
this._initialState = this.value;
Expand Down

0 comments on commit 6be8f30

Please sign in to comment.