Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Commit

Permalink
fix(context-dialog): Remove deprecated aria-label input attribute and…
Browse files Browse the repository at this point in the history
… makes elementRef mandatory.

BREAKING CHANGE: Old attributes do not conform with accessibility standards.
  • Loading branch information
rowa-audil authored and ffriedl89 committed May 12, 2020
1 parent 695fd35 commit b5d0136
Showing 1 changed file with 1 addition and 16 deletions.
17 changes: 1 addition & 16 deletions libs/barista-components/context-dialog/src/context-dialog.ts
Original file line number Diff line number Diff line change
Expand Up @@ -147,20 +147,6 @@ export class DtContextDialog extends _DtContextDialogMixinBase
/** Aria reference to a label describing the context-dialog. */
@Input('aria-labelledby') ariaLabelledBy: string;

/**
* Aria label of the context-dialog's close button.
* @deprecated `aria-label-close-button` does not conform with accessibility standards.
* Please use `ariaLabelClose` input instead.
* @breaking-change Will be removed in version 7.0.0
*/
@Input('aria-label-close-button')
get depAriaLabelClose(): string {
return this._ariaLabelClose;
}
set depAriaLabelClose(value: string) {
this._ariaLabelClose = value;
}

/** Aria label of the context-dialog's close button. */
@Input()
get ariaLabelClose(): string {
Expand Down Expand Up @@ -215,11 +201,10 @@ export class DtContextDialog extends _DtContextDialogMixinBase
private _viewContainerRef: ViewContainerRef,
private _changeDetectorRef: ChangeDetectorRef,
private _focusTrapFactory: FocusTrapFactory,
private _elementRef: ElementRef<HTMLElement>,
@Attribute('tabindex') tabIndex: string,
// tslint:disable-next-line: no-any
@Optional() @Inject(DOCUMENT) private _document: any,
/** @breaking-change: `_elementRef` will be mandatory with version 7.0.0 */
private _elementRef?: ElementRef<HTMLElement>,
@Optional()
@Inject(DT_UI_TEST_CONFIG)
private _config?: DtUiTestConfiguration,
Expand Down

0 comments on commit b5d0136

Please sign in to comment.