chore: Add PR review comments

dynatrace-oss · Feb 28, 2020 · d1502af · d1502af
1 parent 44e67bc
commit d1502af
Show file tree

Hide file tree

Showing 6 changed files with 5 additions and 26 deletions.
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -143,6 +143,7 @@ jobs:
   sonar:
     <<: *defaults
     environment:
+      # - sonar needs more memory for the scanner run if a LOT of files are changed
       SONAR_SCANNER_OPTS: -Xmx1024m
     steps:
       - attach_workspace:

diff --git a/.vscode/launch.json b/.vscode/launch.json
diff --git a/libs/barista-components/schematics/collection.json b/libs/barista-components/schematics/collection.json
@@ -1,5 +1,5 @@
 {
-  "$schema": "../../node_modules/@angular-devkit/schematics/collection-schema.json",
+  "$schema": "../../../node_modules/@angular-devkit/schematics/collection-schema.json",
   "schematics": {
     "ng-add": {
       "description": "Add and migrate Dynatrace Angular Components to v5.",

diff --git a/libs/barista-components/schematics/migration.json b/libs/barista-components/schematics/migration.json
@@ -1,5 +1,5 @@
 {
-  "$schema": "../../node_modules/@angular-devkit/schematics/collection-schema.json",
+  "$schema": "../../../node_modules/@angular-devkit/schematics/collection-schema.json",
   "schematics": {
     "update-5.0.0": {
       "version": "5.0.0",

diff --git a/sonar-project.properties b/sonar-project.properties
@@ -11,4 +11,5 @@ sonar.sources=.
 # Encoding of the source code. Default is default system encoding
 sonar.sourceEncoding=UTF-8
 
+# Exlcuding the files for the schematics to avoid sonar errors
 sonar.exclusions=tools/schematics/**
diff --git a/tools/tslint-rules/tslint.json b/tools/tslint-rules/tslint.json
@@ -1,3 +1,3 @@
 {
-  "extends": "../../../tslint.json"
+  "extends": "../../tslint.json"
 }