fix(chart): Fixes an issue with the overlay of the selection area not

updating. Fixes #608
dynatrace-oss · Feb 17, 2020 · d640ee4 · d640ee4
1 parent ad5bc8f
commit d640ee4
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 1 deletion.
diff --git a/apps/dev/src/chart/chart-demo.component.html b/apps/dev/src/chart/chart-demo.component.html
@@ -90,7 +90,7 @@
     (valueChanges)="onTimeframeChanges($event)"
   ></dt-chart-timestamp>
 </dt-chart>
-
+<button (click)="setTimeframe()">set timeframe</button>
 <button (click)="switchData()">change</button>
 
 <dt-chart

diff --git a/apps/dev/src/chart/chart-demo.component.ts b/apps/dev/src/chart/chart-demo.component.ts
@@ -94,4 +94,12 @@ export class ChartDemo {
   seriesVisibilityChanged(event: DtChartSeriesVisibilityChangeEvent): void {
     console.log(event);
   }
+
+  setTimeframe(): void {
+    this.lastTimeframe = [
+      this.lastTimeframe[0] - 100_000,
+      this.lastTimeframe[1] + 100_000,
+    ];
+    this.dtChartRange.value = this.lastTimeframe;
+  }
 }
diff --git a/components/chart/src/selection-area/selection-area.ts b/components/chart/src/selection-area/selection-area.ts
@@ -40,6 +40,7 @@ import {
   ViewChild,
   ViewContainerRef,
   ViewEncapsulation,
+  ChangeDetectorRef,
 } from '@angular/core';
 import {
   _addCssClass,
@@ -185,6 +186,7 @@ export class DtChartSelectionArea implements AfterContentInit, OnDestroy {
     private _viewportRuler: ViewportRuler,
     private _platform: Platform,
     private _overlayContainer: OverlayContainer,
+    private _changeDetectorRef: ChangeDetectorRef,
     // tslint:disable-next-line: no-any
     @Inject(DOCUMENT) private _document: any,
     @Optional() private _viewportResizer: DtViewportResizer,
@@ -828,6 +830,7 @@ export class DtChartSelectionArea implements AfterContentInit, OnDestroy {
               ref,
               viewPortOffset,
             );
+            this._changeDetectorRef.markForCheck();
           }
         });
     }