refactor(table): Remove unnecessary ng_Zone from constructor and tabl…

…e empty states. BREAKING CHANGE: No more NgZone element and use `<dt-empty-state>` instead.
dynatrace-oss · May 12, 2020 · de89e60 · de89e60
1 parent 550fdcd
commit de89e60
Show file tree

Hide file tree

Showing 12 changed files with 1 addition and 259 deletions.
diff --git a/libs/barista-components/table/src/states/index.ts b/libs/barista-components/table/src/states/index.ts
@@ -14,8 +14,4 @@
  * limitations under the License.
  */
 
-export * from './table-empty-state';
-export * from './table-empty-state-image';
-export * from './table-empty-state-message';
-export * from './table-empty-state-title';
 export * from './table-loading-state';
diff --git a/libs/barista-components/table/src/states/table-empty-state-image.scss b/libs/barista-components/table/src/states/table-empty-state-image.scss
diff --git a/libs/barista-components/table/src/states/table-empty-state-image.ts b/libs/barista-components/table/src/states/table-empty-state-image.ts
diff --git a/libs/barista-components/table/src/states/table-empty-state-message.scss b/libs/barista-components/table/src/states/table-empty-state-message.scss
diff --git a/libs/barista-components/table/src/states/table-empty-state-message.ts b/libs/barista-components/table/src/states/table-empty-state-message.ts
diff --git a/libs/barista-components/table/src/states/table-empty-state-title.scss b/libs/barista-components/table/src/states/table-empty-state-title.scss
diff --git a/libs/barista-components/table/src/states/table-empty-state-title.ts b/libs/barista-components/table/src/states/table-empty-state-title.ts
diff --git a/libs/barista-components/table/src/states/table-empty-state.html b/libs/barista-components/table/src/states/table-empty-state.html
diff --git a/libs/barista-components/table/src/states/table-empty-state.scss b/libs/barista-components/table/src/states/table-empty-state.scss
diff --git a/libs/barista-components/table/src/states/table-empty-state.ts b/libs/barista-components/table/src/states/table-empty-state.ts
diff --git a/libs/barista-components/table/src/table-module.ts b/libs/barista-components/table/src/table-module.ts
@@ -48,14 +48,7 @@ import {
 } from './simple-columns/index';
 import { DtSort } from './sort/sort';
 import { DtSortHeader } from './sort/sort-header';
-import {
-  DtTableEmptyState,
-  DtTableEmptyStateDirective,
-  DtTableEmptyStateImage,
-  DtTableEmptyStateMessage,
-  DtTableEmptyStateTitle,
-  DtTableLoadingState,
-} from './states/index';
+import { DtTableLoadingState } from './states/index';
 import { DtTable } from './table';
 
 const EXPORTED_DECLARATIONS = [
@@ -71,11 +64,6 @@ const EXPORTED_DECLARATIONS = [
   DtExpandableRow,
   DtHeaderCell,
   DtHeaderCellDef,
-  DtTableEmptyState, // tslint:disable-line:deprecation
-  DtTableEmptyStateDirective, // tslint:disable-line:deprecation
-  DtTableEmptyStateImage, // tslint:disable-line:deprecation
-  DtTableEmptyStateTitle, // tslint:disable-line:deprecation
-  DtTableEmptyStateMessage, // tslint:disable-line:deprecation
   DtTableLoadingState,
   DtSort,
   DtSortHeader,

diff --git a/libs/barista-components/table/src/table.ts b/libs/barista-components/table/src/table.ts
@@ -28,7 +28,6 @@ import {
   Inject,
   Input,
   IterableDiffers,
-  NgZone,
   OnDestroy,
   QueryList,
   TemplateRef,
@@ -150,8 +149,6 @@ export class DtTable<T> extends _DtTableBase<T> implements OnDestroy {
     changeDetectorRef: ChangeDetectorRef,
     elementRef: ElementRef,
     @Attribute('role') role: string,
-    /** @breaking-change: ngZone is no longer necessary in the table injectors, will be removed with 7.0.0 */
-    _ngZone: NgZone,
     // tslint:disable-next-line: no-any
     @Inject(DOCUMENT) document: any,
     platform: Platform,