Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Custom properties: Add mixin containing properties that are redundantly defined multiple times #1056

Closed
rowa-audil opened this issue May 20, 2020 · 0 comments · Fixed by #1286
Closed

Custom properties: Add mixin containing properties that are redundantly defined multiple times #1056

rowa-audil opened this issue May 20, 2020 · 0 comments · Fixed by #1286
Assignees
@tomheller
Labels
feature has-pr quality All topics that concern the code quality.

Comments

@rowa-audil
Copy link
Contributor

Let's add a mixin for all colors which are needlessly defined in multiple themes.
@rowa-audil rowa-audil added feature quality All topics that concern the code quality. labels May 20, 2020
@rowa-audil rowa-audil mentioned this issue May 20, 2020
Merged
tomheller added a commit that referenced this issue Jul 14, 2020
@tomheller
feat(progress-bar): Switched theming to custom properties.
f9c60be 
Additionally added a shared definition of the common colors.
Fixes #1056
@tomheller tomheller mentioned this issue Jul 14, 2020
Merged
4 tasks
@tomheller tomheller self-assigned this Jul 14, 2020
tomheller added a commit that referenced this issue Jul 14, 2020
@tomheller
feat(progress-bar): Switched theming to custom properties.
b18629d 
Additionally added a shared definition of the common colors.
Fixes #1056
ffriedl89 pushed a commit that referenced this issue Jul 15, 2020
@tomheller @ffriedl89
feat(progress-bar): Switched theming to custom properties.
0839e7c 
Additionally added a shared definition of the common colors.
Fixes #1056
github-actions bot pushed a commit that referenced this issue Jul 15, 2020
@tomheller @ffriedl89
feat(progress-bar): Switched theming to custom properties.
d49a9ec 
Additionally added a shared definition of the common colors.
Fixes #1056
yngrdyn pushed a commit to yngrdyn/barista that referenced this issue Nov 9, 2020
@tomheller
feat(progress-bar): Switched theming to custom properties.
a396ca0 
Additionally added a shared definition of the common colors.
Fixes dynatrace-oss#1056
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@tomheller tomheller

Labels
feature has-pr quality All topics that concern the code quality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(progress-bar): Switched theming to custom properties. dynatrace-oss/barista
2 participants
@tomheller @rowa-audil