Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

(font-styles.scss) default font definition for h3 is missing #1081

Closed
DorotkaMakotka opened this issue May 26, 2020 · 2 comments · Fixed by #1082
Closed

(font-styles.scss) default font definition for h3 is missing #1081

DorotkaMakotka opened this issue May 26, 2020 · 2 comments · Fixed by #1082
Assignees
Labels
bug A broken behaviour that was working previously

Comments

@DorotkaMakotka
Copy link
Contributor

Bug Report

Expected Behavior

font-styless.scss (which is imported i.a. into cluster global styles) is expected to provide and ensure all font styling in accordance with barista design system, including the entry below:

h3 {
  @include dt-h3-font();
}

Current Behavior

Style definition for h3 is missing (since https://github.com/dynatrace-oss/barista/pull/550/files?file-filters%5B%5D=.scss)

Possible Solution

Steps to Reproduce

Context (Environment)

Used Versions:

  • node:
  • npm:
  • typescript:
  • angular:
  • @angular/cdk:
  • @dynatrace/barista-components:

Detailed Description

Possible Implementation

Attachments

@DorotkaMakotka DorotkaMakotka added the bug A broken behaviour that was working previously label May 26, 2020
@tomheller
Copy link
Collaborator

Thanks @DorotkaMakotka for noticing and fixing this 👍

@DorotkaMakotka
Copy link
Contributor Author

(I'll push the fix in a moment)

DorotkaMakotka pushed a commit to DorotkaMakotka/barista that referenced this issue May 26, 2020
@tomheller tomheller linked a pull request May 26, 2020 that will close this issue
4 tasks
DorotkaMakotka added a commit to DorotkaMakotka/barista that referenced this issue May 26, 2020
yngrdyn pushed a commit to yngrdyn/barista that referenced this issue Nov 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug A broken behaviour that was working previously
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants