Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Checkbox & Switch should also work with a form-field #1120

Closed
thomaspink opened this issue Jun 5, 2020 · 0 comments · Fixed by #1133
Closed

Checkbox & Switch should also work with a form-field #1120

thomaspink opened this issue Jun 5, 2020 · 0 comments · Fixed by #1133
Assignees
@thomaspink
Labels
feature has-pr P1 Urgent issue that should be resolved before the next release
Milestone
Sprint 197

Comments

@thomaspink
Copy link
Contributor

Feature Request

Summary

Currently the checkbox & switch components do not work with the form-field even as they are input components that represent a single value.

Feature Description

Checkbox & Switch should implement the DtFormFieldControl to ensure they work with a DtFormField.

The value of the checkbox/switch in the formfield should bei the passed in Generic value type if the it is checked or undefined if not.
@thomaspink thomaspink added P1 Urgent issue that should be resolved before the next release feature labels Jun 5, 2020
@thomaspink thomaspink self-assigned this Jun 5, 2020
@ffriedl89 ffriedl89 added this to the Sprint 197 milestone Jun 8, 2020
thomaspink added a commit that referenced this issue Jun 8, 2020
@thomaspink
feat(checkbox): Added support as a form-field-control.
d7273ce 
Fixes #1120
@thomaspink thomaspink mentioned this issue Jun 8, 2020
Merged
thomaspink added a commit that referenced this issue Jun 9, 2020
@thomaspink
feat(checkbox): Added support as a form-field-control.
a63705e 
Fixes #1120
thomaspink added a commit that referenced this issue Jun 12, 2020
@thomaspink
feat(checkbox, switch): Added support as a form-field-control.
ed43511 
Fixes #1120
tomheller pushed a commit that referenced this issue Jun 15, 2020
@thomaspink @tomheller
feat(checkbox, switch): Added support as a form-field-control.
12ce794 
Fixes #1120
github-actions bot pushed a commit that referenced this issue Jun 15, 2020
@thomaspink @tomheller
feat(checkbox, switch): Added support as a form-field-control.
3e84703 
Fixes #1120
yngrdyn pushed a commit to yngrdyn/barista that referenced this issue Nov 9, 2020
@thomaspink
feat(checkbox, switch): Added support as a form-field-control.
000b578 
Fixes dynatrace-oss#1120
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@thomaspink thomaspink

Labels
feature has-pr P1 Urgent issue that should be resolved before the next release
Projects
None yet
Milestone
Sprint 197
Development

Successfully merging a pull request may close this issue.

Added support for checkbox/switch as a form-field-control. dynatrace-oss/barista
2 participants
@thomaspink @ffriedl89