Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Add directive for text to confirmation dialog to make styling easier #1148

Closed
SirTroyer opened this issue Jun 9, 2020 · 1 comment · Fixed by #1232
Closed

Add directive for text to confirmation dialog to make styling easier #1148

SirTroyer opened this issue Jun 9, 2020 · 1 comment · Fixed by #1232
Labels

Comments

@SirTroyer
Copy link
Contributor

Feature Request

Summary

Add directive for text in a confirmation dialog to make styling easier when dt-confirmation-dialog-state also consists of dt-confirmation-dialog-actions. In which case the user would have to style the text himself to introduce a little margin between text and buttons.

Feature Description

Currently, there is a directive for actions in a dt-confirmation-dialog-state which is called dt-confirmation-dialog-actions. Text can be inserted anywhere in the dt-confirmation-dialog-state
but if a user wants to use text and buttons at the same time in the confirmation dialog, which is often the case, the user has to style the text himself to create a little margin between text and buttons.
It would be cool for the text to have its own directive that will style it.

confirmation-dialog

@tomheller
Copy link
Collaborator

Hi @SirTroyer!

Instead of adding an additional directive for the text, as this can be styled however consumers want, as long as they create their own wrapping element, I would opt to add styling to the class applied to the dt-confirmation-dialog-actions directive and add the spacing there.

The default ng-content should still work the same without requiring an extra wrapping element for the text itself.

Would this also work for you?

@tomheller tomheller added help wanted Extra attention is needed needs discussion labels Jun 10, 2020
bartoszbobin added a commit to bartoszbobin/barista that referenced this issue Jul 6, 2020
…ontent and actions is too small.

Fixes dynatrace-oss#1148

Signed-off-by: Bartosz Bobin <bartosz.bobin@dynatrace.com>
tomheller pushed a commit that referenced this issue Jul 7, 2020
…ontent and actions is too small.

Fixes #1148

Signed-off-by: Bartosz Bobin <bartosz.bobin@dynatrace.com>
tomheller pushed a commit that referenced this issue Jul 7, 2020
…ontent and actions is too small.

Fixes #1148

Signed-off-by: Bartosz Bobin <bartosz.bobin@dynatrace.com>
tomheller pushed a commit that referenced this issue Jul 7, 2020
…ontent and actions is too small.

Fixes #1148

Signed-off-by: Bartosz Bobin <bartosz.bobin@dynatrace.com>
yngrdyn pushed a commit to yngrdyn/barista that referenced this issue Nov 9, 2020
…ontent and actions is too small.

Fixes dynatrace-oss#1148

Signed-off-by: Bartosz Bobin <bartosz.bobin@dynatrace.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants