This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 78
[Filter field]: Add information about interaction level on the filter field. #1321
Labels
feature
filter-field
Temporary label for filter field issues
good first issue
Good for newcomers
Hacktoberfest 🎃
Issues that might be easy to start with: https://hacktoberfest.digitalocean.com/
help wanted
Extra attention is needed
Comments
tomheller
changed the title
Filter field: Add information about interaction level on the filter field.
[Filter-field]: Add information about interaction level on the filter field.
Jul 20, 2020
Hi @tomheller, |
I can see both the ouput and the boolean property being useful. I am also not quite convinced about the naming tbh. |
I think it's a good point to go with |
tomheller
changed the title
[Filter-field]: Add information about interaction level on the filter field.
[Filter field]: Add information about interaction level on the filter field.
Aug 7, 2020
lukasholzer
added
the
Hacktoberfest 🎃
Issues that might be easy to start with: https://hacktoberfest.digitalocean.com/
label
Oct 1, 2020
Moved to internal issue tracking. |
4 tasks
rowa-audil
added a commit
that referenced
this issue
Dec 17, 2020
This helps to determine when it is safe to update the datasource of the filter field, without breaking the experience of the user. Fixes #1321 Co-authored-by: Thomas Heller <thomas.heller@dynatrace.com>
rowa-audil
added a commit
that referenced
this issue
Dec 18, 2020
This helps to determine when it is safe to update the datasource of the filter field, without breaking the experience of the user. Fixes #1321 Co-authored-by: Thomas Heller <thomas.heller@dynatrace.com>
ffriedl89
pushed a commit
that referenced
this issue
Dec 18, 2020
This helps to determine when it is safe to update the datasource of the filter field, without breaking the experience of the user. Fixes #1321 Co-authored-by: Thomas Heller <thomas.heller@dynatrace.com>
github-actions bot
pushed a commit
that referenced
this issue
Dec 18, 2020
This helps to determine when it is safe to update the datasource of the filter field, without breaking the experience of the user. Fixes #1321 Co-authored-by: Thomas Heller <thomas.heller@dynatrace.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
feature
filter-field
Temporary label for filter field issues
good first issue
Good for newcomers
Hacktoberfest 🎃
Issues that might be easy to start with: https://hacktoberfest.digitalocean.com/
help wanted
Extra attention is needed
Feature Request
Summary
Add an
@Output
and a property to the filter field that indicates whether the user is currently using the filter field. This will help consumers to determine when it is safe to update filter-definitions (datasource) without crashing the user flow of the user.The output can be useful to react to changes in the interaction-behaviour, whereas the property can be used for onDemand checks if it is now safe to update the datasource.
This state will probably need to determine the following things:
Proposal
Add the following to the filter field.
I'm happy to accept feedback, especially on the naming as I'm not sure how well this naming fits.
@Output() inFlightChange: EventEmitter<FilterFieldInFlightChange<boolean>>
Fires when the user starts interacting with the filter field or stops interacting with it.
inFlight: boolean
Determines if the user is currently interacting with the filter field or not.
Please add your considerations, especially pinging @ffriedl89 @thomaspink @ap-dyna
The text was updated successfully, but these errors were encountered: