This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 78
[Table] Using dtExpandableRowContent and dtSort together creates rows with spacing #1353
Comments
Thank you for reporting this issue! Do you want to contribute the fix to the library @areknow? |
@areknow I found the root cause for that problem, which seems to be tied to the internal rendering scheme of the table and the angular animation used to set the expand / collapse states. |
tomheller
added a commit
that referenced
this issue
Jul 27, 2020
… after table-sorting. The internal recycling of nodes within a table did not get picked up by the angular animation used to expand and collapse the rows. We needed to recreate the animation programmatically with the help of the AnimationBuilder and trigger the animation by hand, each time recreating the player. Fixes #1353
Merged
4 tasks
tomheller
added a commit
that referenced
this issue
Jul 27, 2020
… after table-sorting. The internal recycling of nodes within a table did not get picked up by the angular animation used to expand and collapse the rows. We needed to recreate the animation programmatically with the help of the AnimationBuilder and trigger the animation by hand, each time recreating the player. Fixes #1353
ffriedl89
pushed a commit
that referenced
this issue
Jul 27, 2020
… after table-sorting. The internal recycling of nodes within a table did not get picked up by the angular animation used to expand and collapse the rows. We needed to recreate the animation programmatically with the help of the AnimationBuilder and trigger the animation by hand, each time recreating the player. Fixes #1353
github-actions bot
pushed a commit
that referenced
this issue
Jul 27, 2020
… after table-sorting. The internal recycling of nodes within a table did not get picked up by the angular animation used to expand and collapse the rows. We needed to recreate the animation programmatically with the help of the AnimationBuilder and trigger the animation by hand, each time recreating the player. Fixes #1353
github-actions bot
pushed a commit
that referenced
this issue
Jul 27, 2020
… after table-sorting. The internal recycling of nodes within a table did not get picked up by the angular animation used to expand and collapse the rows. We needed to recreate the animation programmatically with the help of the AnimationBuilder and trigger the animation by hand, each time recreating the player. Fixes #1353
yngrdyn
pushed a commit
to yngrdyn/barista
that referenced
this issue
Nov 9, 2020
… after table-sorting. The internal recycling of nodes within a table did not get picked up by the angular animation used to expand and collapse the rows. We needed to recreate the animation programmatically with the help of the AnimationBuilder and trigger the animation by hand, each time recreating the player. Fixes dynatrace-oss#1353
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Bug Report
Hi team, I noticed today that since upgrading to v7.4.0, a new issue is present with the DtTable that uses DtSort along with DtExpandableRowContent.
For some reason I am NOT able to reproduce the bug in stackblitz. Only by creating a fresh Angular project was I able to make a reproduction.
Expected Behavior
The beautiful table should remain beautiful, no extra spacing between each row after clicking on a sort header.
Current Behavior
When using the sort functionality on a DtTable that also has expandable rows, some extra spacing is introduced below each row AFTER clicking on the sort header.
Steps to Reproduce
npm i
npm run start
Context (Environment)
Used Versions:
The text was updated successfully, but these errors were encountered: