Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

[Table] Using dtExpandableRowContent and dtSort together creates rows with spacing #1353

Closed
areknow opened this issue Jul 22, 2020 · 2 comments · Fixed by #1372
Closed

[Table] Using dtExpandableRowContent and dtSort together creates rows with spacing #1353

areknow opened this issue Jul 22, 2020 · 2 comments · Fixed by #1372
Labels
bug A broken behaviour that was working previously has-pr

Comments

@areknow
Copy link
Contributor

areknow commented Jul 22, 2020

Bug Report

Hi team, I noticed today that since upgrading to v7.4.0, a new issue is present with the DtTable that uses DtSort along with DtExpandableRowContent.

Screen Shot 2020-07-22 at 5 02 35 PM

For some reason I am NOT able to reproduce the bug in stackblitz. Only by creating a fresh Angular project was I able to make a reproduction.

Expected Behavior

The beautiful table should remain beautiful, no extra spacing between each row after clicking on a sort header.

Current Behavior

When using the sort functionality on a DtTable that also has expandable rows, some extra spacing is introduced below each row AFTER clicking on the sort header.

Steps to Reproduce

  1. clone: https://github.com/areknow/barista-table-expander-sort-bug.git
  2. npm i
  3. npm run start
  4. click on a table column header to activate sorting
  5. observe that each row now has additional spacing below it that was not there before

Context (Environment)

Used Versions:

  • angular: 9
  • @angular/cdk: ^9.1.0
  • @dynatrace/barista-components: 7.4.0
@areknow areknow added the bug A broken behaviour that was working previously label Jul 22, 2020
@lukasholzer
Copy link
Contributor

Thank you for reporting this issue! Do you want to contribute the fix to the library @areknow?

@tomheller
Copy link
Collaborator

@areknow I found the root cause for that problem, which seems to be tied to the internal rendering scheme of the table and the angular animation used to set the expand / collapse states.
I'm currently trying to figure out how we can circumvent this issue.

tomheller added a commit that referenced this issue Jul 27, 2020
… after table-sorting.

The internal recycling of nodes within a table did not get picked up by the angular animation used
to expand and collapse the rows. We needed to recreate the animation programmatically with the help
of the AnimationBuilder and trigger the animation by hand, each time recreating the player.

Fixes #1353
tomheller added a commit that referenced this issue Jul 27, 2020
… after table-sorting.

The internal recycling of nodes within a table did not get picked up by the angular animation used
to expand and collapse the rows. We needed to recreate the animation programmatically with the help
of the AnimationBuilder and trigger the animation by hand, each time recreating the player.

Fixes #1353
ffriedl89 pushed a commit that referenced this issue Jul 27, 2020
… after table-sorting.

The internal recycling of nodes within a table did not get picked up by the angular animation used
to expand and collapse the rows. We needed to recreate the animation programmatically with the help
of the AnimationBuilder and trigger the animation by hand, each time recreating the player.

Fixes #1353
github-actions bot pushed a commit that referenced this issue Jul 27, 2020
… after table-sorting.

The internal recycling of nodes within a table did not get picked up by the angular animation used
to expand and collapse the rows. We needed to recreate the animation programmatically with the help
of the AnimationBuilder and trigger the animation by hand, each time recreating the player.

Fixes #1353
github-actions bot pushed a commit that referenced this issue Jul 27, 2020
… after table-sorting.

The internal recycling of nodes within a table did not get picked up by the angular animation used
to expand and collapse the rows. We needed to recreate the animation programmatically with the help
of the AnimationBuilder and trigger the animation by hand, each time recreating the player.

Fixes #1353
yngrdyn pushed a commit to yngrdyn/barista that referenced this issue Nov 9, 2020
… after table-sorting.

The internal recycling of nodes within a table did not get picked up by the angular animation used
to expand and collapse the rows. We needed to recreate the animation programmatically with the help
of the AnimationBuilder and trigger the animation by hand, each time recreating the player.

Fixes dynatrace-oss#1353
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug A broken behaviour that was working previously has-pr
Projects
None yet
3 participants