[Expandable Section] Boolean coercion not working correctly for expanded property
#1472
Comments
|
Hey @areknow thank you very much for reporting this, but I cannot reproduce this in stackblitz Furthermore, when I look at the code the Are you sure that you use the component correctly? @Input()
get expanded(): boolean {
return this._panel.expanded;
}
set expanded(value: boolean) {
this._panel.expanded = coerceBooleanProperty(value);
this._changeDetectorRef.markForCheck();
} |
|
Hi @lukasholzer! I also was not able to reproduce in stackblitz so I created a minimal repo. This might indicate an issue with ivy which is not happening with view renderer. Were you able to clone the repo and see the console error? |
|
Hello @lukasholzer, |
|
@areknow Could you try to use the material expandable in your app and compare the behavior. I am curious whether we have some compilation issue with ivy compatibility. This would be a minimal setup https://stackblitz.com/edit/angular-rubmxc?file=src/app/expansion-steps-example.html |
|
@areknow I cloned your repo did an npm install and now an ng serve:
besides that please update the |
|
@ffriedl89 I imported the @lukasholzer I removed |
|
@areknow i put the not-reproduceable label on it as I see the error above when I want to serve the app. So i cannot serve the application. It is not possible to let your repo run for me. Steps I made:
|
|
@lukasholzer I have run the repo on three separate machines. Not sure what the issue is, its a super basic project 🤔 |
|
@lukasholzer Following the commands stated in your post, I'll able to run the project without any issue |
|
@lukasholzer I, too, have been able to reproduce the issue with successful compilation message.
Results: |
|
@areknow hey @thomaspink and myself found the issue we will fix! :) Wondering how this can work even in VE as we are trying to set a property on the Is this an urgent fix for you or are you ok to get it with 8.0.0 otherwise we have to do a backport for this issue. |
|
Fixed by PR #1491 |
|
@lukasholzer thats great news! I performed a hot fix for my app, so I can wait till 8.0.0. Thanks! |
…a dom attribute for `disabled` and `expandable` is not applied correctly. Fixes dynatrace-oss#1489 Fixes dynatrace-oss#1472
Bug Report
Howdy team! It seems that the
expandedproperty is not working with coercion, but is working correctly if set as:[expanded]="true". This was working fine for a long time, but just recently stopped working and is preventing one of my production pages from rendering correctly: https://ci360.dynatrace.com/account/environment/cloud/managed/298Expected Behavior
I expect the following to work as usual:
<dt-expandable-section expanded>Current Behavior
Possible Solution
<dt-expandable-section [expanded]="true">Steps to Reproduce
clone: https://github.com/areknow/a-expandable-section-demo and run
Used Versions:
Thank you very much for your hard work!
The text was updated successfully, but these errors were encountered: