-
Notifications
You must be signed in to change notification settings - Fork 78
Filter Field Autocomplete Panel appears above page header #1747
Comments
I tried to investigate the issue and prepare a fix. I hope that you can push me in the right direction. I've noticed that the Strategy used for popup positioning is relying only on viewport position, unaware of any sticky elements positioning. I've tried to use Is this own viewport implementation idea the right approach here? |
@anntr Thx for helping out with the investigation. I've done a deeper dive just right now to figure out what is going on. The issue that I see is that the filter field / autocomplete does not set the viewportMargin on the DtFlexibleConnectedPositionStrategy. Therefore the viewport margin is always 0 since we default back to it. It should be enough to do the same thing as in the selection-area. |
…ot react to viewport boundaries correctly. Closes #1747.
…ot react to viewport boundaries correctly. Closes #1747.
…ot react to viewport boundaries correctly. Closes #1747.
…ot react to viewport boundaries correctly. Closes #1747.
…ot react to viewport boundaries correctly. Closes #1747.
…ot react to viewport boundaries correctly. Closes #1747.
…ot react to viewport boundaries correctly. Closes #1747.
…ot react to viewport boundaries correctly. Closes dynatrace-oss#1747.
Bug Report
Expected Behavior
autocomplete panel should not overlay sticky header
Current Behavior
autocomplete panel overlays sticky header
Steps to Reproduce
https://stackblitz.com/edit/github-denej4?file=src/app/app.component.html
Filter by
inputContext (Environment)
I can see in Stackblitz that the
dt-autocomplete-panel
is rendered insidecdk-overlay-container
,cdk-overlay-container
is rendered outside the app root and has z-index: 1000 thus covering everything.Exactly same issue was reported and fixed in #451.
Is Stackblitz example valid and something might have broken in Barista after #451 fix?
Do I miss something in the Stackblitz example that would make the
dt-autocomplete-panel
overlay respect fixed header positioning?Used Versions:
The text was updated successfully, but these errors were encountered: