Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Filter Field: Freetext node is instantly submitted with ENTER #294

Closed
ffriedl89 opened this issue Dec 5, 2019 · 1 comment · Fixed by #394 or #404
Closed

Filter Field: Freetext node is instantly submitted with ENTER #294

ffriedl89 opened this issue Dec 5, 2019 · 1 comment · Fixed by #394 or #404
Assignees
Labels
bug A broken behaviour that was working previously has-pr P2 Issue that is important to resolve as soon as possible

Comments

@ffriedl89
Copy link
Collaborator

Bug Report

Expected Behavior

When a freentext node is highlighted in the autocomplete and the user presses ENTER the cursor is placed inside the input field but the freetext is not submitted

Current Behavior

When a freetext node is highlighted in the autocomplete and the user presses ENTER the freetext is instantly submitted with an empty value and therefore an error message is shown for the freetext to be required.

Possible Solution

Handle ENTER the same way as the click on the freetext node in the autocomplete. It's probably a event bubbling issue

Steps to Reproduce

  1. select a freetext node with the keyboard and press enter when highlighted
@ffriedl89 ffriedl89 added bug A broken behaviour that was working previously P2 Issue that is important to resolve as soon as possible labels Dec 5, 2019
@thomaspink thomaspink added this to the Filter field milestone Dec 9, 2019
@tomheller tomheller self-assigned this Jan 8, 2020
tomheller added a commit that referenced this issue Jan 8, 2020
… the event chart.

To provide more control over the selection model of the events within the event chart,
we exposed the select, deselect and closeOverlay methods. This way, the consumer
can control selection better.

Closes #294
tomheller added a commit that referenced this issue Jan 8, 2020
… the event chart.

To provide more control over the selection model of the events within the event chart,
we exposed the select, deselect and closeOverlay methods. This way, the consumer
can control selection better.

Closes #294
tomheller added a commit that referenced this issue Jan 8, 2020
… the event chart.

To provide more control over the selection model of the events within the event chart,
we exposed the select, deselect and closeOverlay methods. This way, the consumer
can control selection better.

Closes #294
tomheller added a commit that referenced this issue Jan 8, 2020
… the event chart.

To provide more control over the selection model of the events within the event chart,
we exposed the select, deselect and closeOverlay methods. This way, the consumer
can control selection better.

Closes #294
tomheller added a commit that referenced this issue Jan 8, 2020
… the event chart.

To provide more control over the selection model of the events within the event chart,
we exposed the select, deselect and closeOverlay methods. This way, the consumer
can control selection better.

Closes #294
@tomheller
Copy link
Collaborator

Sorry for referencing the wrong issue in the event chart commit, this has now been removed in bb77e96

tomheller added a commit that referenced this issue Jan 9, 2020
When selecting a freetext node from the autocomplete with the keyboard
the the different eventHandlers of the autocomplete and the filterfield
raced to a broken state. To prevent the instant submission of an empty
free-text when selecting it with the keyboard, we are now checking for a
value in the free-text submission.

Fixes #294
tomheller added a commit that referenced this issue Jan 10, 2020
When selecting a freetext node from the autocomplete with the keyboard
the the different eventHandlers of the autocomplete and the filterfield
raced to a broken state. To prevent the instant submission of an empty
filter we are handling the locking of the input field and synching that
lock with the zone cycle.
Additionally this commit implements a fix for submission of empty values
if the value and submission happend in a shorter time than the
DT_FILTER_FIELD_TYPING_DEBOUNCE.

Fixes #294
tomheller added a commit that referenced this issue Jan 13, 2020
When selecting a freetext node from the autocomplete with the keyboard
the the different eventHandlers of the autocomplete and the filterfield
raced to a broken state. To prevent the instant submission of an empty
filter we are handling the locking of the input field and synching that
lock with the zone cycle.
Additionally this commit implements a fix for submission of empty values
if the value and submission happend in a shorter time than the
DT_FILTER_FIELD_TYPING_DEBOUNCE.

Fixes #294
tomheller added a commit that referenced this issue Jan 13, 2020
When selecting a freetext node from the autocomplete with the keyboard
the the different eventHandlers of the autocomplete and the filterfield
raced to a broken state. To prevent the instant submission of an empty
filter we are handling the locking of the input field and synching that
lock with the zone cycle.
Additionally this commit implements a fix for submission of empty values
if the value and submission happend in a shorter time than the
DT_FILTER_FIELD_TYPING_DEBOUNCE.

Fixes #294
tomheller added a commit that referenced this issue Jan 13, 2020
When selecting a freetext node from the autocomplete with the keyboard
the the different eventHandlers of the autocomplete and the filterfield
raced to a broken state. To prevent the instant submission of an empty
filter we are handling the locking of the input field and synching that
lock with the zone cycle.
Additionally this commit implements a fix for submission of empty values
if the value and submission happend in a shorter time than the
DT_FILTER_FIELD_TYPING_DEBOUNCE.

Fixes #294
tomheller added a commit that referenced this issue Jan 13, 2020
When selecting a freetext node from the autocomplete with the keyboard
the the different eventHandlers of the autocomplete and the filterfield
raced to a broken state. To prevent the instant submission of an empty
filter we are handling the locking of the input field and synching that
lock with the zone cycle.
Additionally this commit implements a fix for submission of empty values
if the value and submission happend in a shorter time than the
DT_FILTER_FIELD_TYPING_DEBOUNCE.

Fixes #294
tomheller added a commit that referenced this issue Jan 22, 2020
When selecting a freetext node from the autocomplete with the keyboard
the the different eventHandlers of the autocomplete and the filterfield
raced to a broken state. To prevent the instant submission of an empty
filter we are handling the locking of the input field and synching that
lock with the zone cycle.
Additionally this commit implements a fix for submission of empty values
if the value and submission happend in a shorter time than the
DT_FILTER_FIELD_TYPING_DEBOUNCE.

Fixes #294
tomheller added a commit that referenced this issue Jan 22, 2020
When selecting a freetext node from the autocomplete with the keyboard
the the different eventHandlers of the autocomplete and the filterfield
raced to a broken state. To prevent the instant submission of an empty
filter we are handling the locking of the input field and synching that
lock with the zone cycle.
Additionally this commit implements a fix for submission of empty values
if the value and submission happend in a shorter time than the
DT_FILTER_FIELD_TYPING_DEBOUNCE.

Fixes #294
tomheller added a commit that referenced this issue Jan 22, 2020
When selecting a freetext node from the autocomplete with the keyboard
the the different eventHandlers of the autocomplete and the filterfield
raced to a broken state. To prevent the instant submission of an empty
filter we are handling the locking of the input field and synching that
lock with the zone cycle.
Additionally this commit implements a fix for submission of empty values
if the value and submission happend in a shorter time than the
DT_FILTER_FIELD_TYPING_DEBOUNCE.

Fixes #294
thomaspink pushed a commit that referenced this issue Jan 28, 2020
When selecting a freetext node from the autocomplete with the keyboard
the the different eventHandlers of the autocomplete and the filterfield
raced to a broken state. To prevent the instant submission of an empty
filter we are handling the locking of the input field and synching that
lock with the zone cycle.
Additionally this commit implements a fix for submission of empty values
if the value and submission happend in a shorter time than the
DT_FILTER_FIELD_TYPING_DEBOUNCE.

Fixes #294
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug A broken behaviour that was working previously has-pr P2 Issue that is important to resolve as soon as possible
Projects
None yet
3 participants