This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Filter field: Clear all button requires 2 clicks #435
Assignees
Comments
tomheller
changed the title
tomheller
changed the title
tomheller
added a commit
that referenced
this issue
Jan 16, 2020
…ality. The clearAll button rendering depended on the filterfield not being focussed. When the clearAll button was rendered and was clicked, the cdkFocusMonitor kicked in, set the focus and removed the clearAll button again. As a result the clearAll button lost its focus, the document focus was set back to the body and the clearAll was rendered again. The click event on the clearAll was never fired. We no longer remove the clearAll from the DOM, but hide it via css classes. This makes it not lose focus, and results in a more consistent behavior. Fixes #435
4 tasks
tomheller
added a commit
that referenced
this issue
Jan 16, 2020
…ality. The clearAll button rendering depended on the filterfield not being focussed. When the clearAll button was rendered and was clicked, the cdkFocusMonitor kicked in, set the focus and removed the clearAll button again. As a result the clearAll button lost its focus, the document focus was set back to the body and the clearAll was rendered again. The click event on the clearAll was never fired. We no longer remove the clearAll from the DOM, but hide it via css classes. This makes it not lose focus, and results in a more consistent behavior. Fixes #435
tomheller
added a commit
that referenced
this issue
Jan 20, 2020
…ality. The clearAll button rendering depended on the filterfield not being focussed. When the clearAll button was rendered and was clicked, the cdkFocusMonitor kicked in, set the focus and removed the clearAll button again. As a result the clearAll button lost its focus, the document focus was set back to the body and the clearAll was rendered again. The click event on the clearAll was never fired. We no longer remove the clearAll from the DOM, but hide it via css classes. This makes it not lose focus, and results in a more consistent behavior. Fixes #435
tomheller
added a commit
that referenced
this issue
Jan 22, 2020
…ality. The clearAll button rendering depended on the filterfield not being focussed. When the clearAll button was rendered and was clicked, the cdkFocusMonitor kicked in, set the focus and removed the clearAll button again. As a result the clearAll button lost its focus, the document focus was set back to the body and the clearAll was rendered again. The click event on the clearAll was never fired. We no longer remove the clearAll from the DOM, but hide it via css classes. This makes it not lose focus, and results in a more consistent behavior. Fixes #435
tomheller
added a commit
that referenced
this issue
Jan 22, 2020
…ality. The clearAll button rendering depended on the filterfield not being focussed. When the clearAll button was rendered and was clicked, the cdkFocusMonitor kicked in, set the focus and removed the clearAll button again. As a result the clearAll button lost its focus, the document focus was set back to the body and the clearAll was rendered again. The click event on the clearAll was never fired. We no longer remove the clearAll from the DOM, but hide it via css classes. This makes it not lose focus, and results in a more consistent behavior. Fixes #435
tomheller
added a commit
that referenced
this issue
Jan 31, 2020
…ality. The clearAll button rendering depended on the filterfield not being focussed. When the clearAll button was rendered and was clicked, the cdkFocusMonitor kicked in, set the focus and removed the clearAll button again. As a result the clearAll button lost its focus, the document focus was set back to the body and the clearAll was rendered again. The click event on the clearAll was never fired. We no longer remove the clearAll from the DOM, but hide it via css classes. This makes it not lose focus, and results in a more consistent behavior. Fixes #435
ffriedl89
pushed a commit
that referenced
this issue
Feb 4, 2020
…ality. The clearAll button rendering depended on the filterfield not being focussed. When the clearAll button was rendered and was clicked, the cdkFocusMonitor kicked in, set the focus and removed the clearAll button again. As a result the clearAll button lost its focus, the document focus was set back to the body and the clearAll was rendered again. The click event on the clearAll was never fired. We no longer remove the clearAll from the DOM, but hide it via css classes. This makes it not lose focus, and results in a more consistent behavior. Fixes #435
github-actions bot
pushed a commit
that referenced
this issue
Feb 4, 2020
…ality. The clearAll button rendering depended on the filterfield not being focussed. When the clearAll button was rendered and was clicked, the cdkFocusMonitor kicked in, set the focus and removed the clearAll button again. As a result the clearAll button lost its focus, the document focus was set back to the body and the clearAll was rendered again. The click event on the clearAll was never fired. We no longer remove the clearAll from the DOM, but hide it via css classes. This makes it not lose focus, and results in a more consistent behavior. Fixes #435
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Bug Report
Expected Behavior
"Clear all" should clear all (editable) fields on a single click
Current Behavior
I have to click "Clear all" twice to remove the fields
(In some cases the button never has a (visual) effect no matter how often I click it until I scroll, but I can't reproduce this consistantly, so hopefully it's the same problem)
Steps to Reproduce
https://barista.dynatrace.com/components/filter-field/#readonly-non-deletable--non-editable-tags
The text was updated successfully, but these errors were encountered: