Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

[Timeline Chart]: Visually complete marker out of the chart #495

Closed
allexcd opened this issue Jan 28, 2020 · 0 comments · Fixed by #512
Closed

[Timeline Chart]: Visually complete marker out of the chart #495

allexcd opened this issue Jan 28, 2020 · 0 comments · Fixed by #512
Assignees
Labels
bug A broken behaviour that was working previously has-pr

Comments

@allexcd
Copy link

allexcd commented Jan 28, 2020

Bug Report

Expected Behavior

Visually complete label should appear to the left of the marker, when it's too close to the right margin

Current Behavior

It appears cut to the right

Used Versions:

  • node: 10.15.0
  • npm: 6.4.1.
  • typescript: 3.5.3
  • angular: 8.2.12
  • @angular/cdk: 8.2.3
  • @dynatrace/barista-components: 5.0.0

Attachments

image

@allexcd allexcd added the bug A broken behaviour that was working previously label Jan 28, 2020
tomheller added a commit that referenced this issue Jan 31, 2020
marker was cut off.

If a key timing marker was rendered too far to the right end of the
chart, the label associated with it was cut off by the container.
We introduced a threshold of 85%, at which point the label would be
rendered on the left hand side of the marker.

Fixes #495
@tomheller tomheller self-assigned this Jan 31, 2020
thomaspink pushed a commit that referenced this issue Jan 31, 2020
marker was cut off.

If a key timing marker was rendered too far to the right end of the
chart, the label associated with it was cut off by the container.
We introduced a threshold of 85%, at which point the label would be
rendered on the left hand side of the marker.

Fixes #495
github-actions bot pushed a commit that referenced this issue Jan 31, 2020
marker was cut off.

If a key timing marker was rendered too far to the right end of the
chart, the label associated with it was cut off by the container.
We introduced a threshold of 85%, at which point the label would be
rendered on the left hand side of the marker.

Fixes #495
github-actions bot pushed a commit that referenced this issue Jan 31, 2020
marker was cut off.

If a key timing marker was rendered too far to the right end of the
chart, the label associated with it was cut off by the container.
We introduced a threshold of 85%, at which point the label would be
rendered on the left hand side of the marker.

Fixes #495
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug A broken behaviour that was working previously has-pr
Projects
None yet
2 participants