Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

[dt-chart-tooltip] Chart tooltip is shown although the chart is removed from Dom. #579

Closed
mohamediab opened this issue Feb 11, 2020 · 2 comments · Fixed by #585
Closed

[dt-chart-tooltip] Chart tooltip is shown although the chart is removed from Dom. #579

mohamediab opened this issue Feb 11, 2020 · 2 comments · Fixed by #585
Assignees
@tomheller
Labels
bug A broken behaviour that was working previously has-pr P1 Urgent issue that should be resolved before the next release

Comments

@mohamediab
Copy link

mohamediab commented Feb 11, 2020 •
edited
Loading

Bug Report

Expected Behavior

Tooltip should be destroyed when the chart is removed from DOM.

Current Behavior

Tooltip is stuck on the screen and can no be removed.

Possible Solution

Tooltip should be destroyed when its parent chart is removed.

Steps to Reproduce

  • hover over a chart so the tooltip is visible
  • apply an action which removes the chart from dom while mouse is still hovering over the chart
  • the tooltip will stay and can not be removed although chart is removed.

Attachments

screenshot1
screenshot2
@mohamediab mohamediab added the bug A broken behaviour that was working previously label Feb 11, 2020
@tomheller tomheller added the P1 Urgent issue that should be resolved before the next release label Feb 12, 2020
@tomheller
Copy link
Collaborator

Hi @mohamediab! Thank you for reporting this one to us.
We were able to reproduce this issue in our dev app and it seems that your proposed solution of destroying the overlay when the chart is destroyed.

@tomheller
Copy link
Collaborator

We have reached out to @mohamediab if he would be able to contribute this bug fix to the library, but due to time constraints, he sadly will not be able to do this at this time. I will take over that issue and see that we can sort this out as soon as possible.

@tomheller tomheller self-assigned this Feb 12, 2020
tomheller added a commit that referenced this issue Feb 12, 2020
@tomheller
fix(chart): Fixes an issue where the tooltip stayed open when the chart
9976d5c 
was destroyed.

Fire the tooltipClose event when the chart is destroyed, so any open
tooltip will close when the parent chart component is destroyed.

Fixes #579
@tomheller tomheller mentioned this issue Feb 12, 2020
Merged
4 tasks
tomheller added a commit that referenced this issue Feb 13, 2020
@tomheller
fix(chart): Fixes an issue where the tooltip stayed open when the chart
0ed1f1c 
was destroyed.

Fire the tooltipClose event when the chart is destroyed, so any open
tooltip will close when the parent chart component is destroyed.

Fixes #579
github-actions bot pushed a commit that referenced this issue Feb 13, 2020
@tomheller
fix(chart): Fixes an issue where the tooltip stayed open when the chart
395fa44 
was destroyed.

Fire the tooltipClose event when the chart is destroyed, so any open
tooltip will close when the parent chart component is destroyed.

Fixes #579
github-actions bot pushed a commit that referenced this issue Feb 13, 2020
@tomheller
fix(chart): Fixes an issue where the tooltip stayed open when the chart
a7e7882 
was destroyed.

Fire the tooltipClose event when the chart is destroyed, so any open
tooltip will close when the parent chart component is destroyed.

Fixes #579
yngrdyn pushed a commit to yngrdyn/barista that referenced this issue Nov 9, 2020
@tomheller
fix(chart): Fixes an issue where the tooltip stayed open when the chart
084151a 
was destroyed.

Fire the tooltipClose event when the chart is destroyed, so any open
tooltip will close when the parent chart component is destroyed.

Fixes dynatrace-oss#579
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@tomheller tomheller

Labels
bug A broken behaviour that was working previously has-pr P1 Urgent issue that should be resolved before the next release
Projects
None yet
Milestone
No milestone
2 participants
@tomheller @mohamediab