Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Copy to clipboard: Support for secondary button styling #76

Closed
ffriedl89 opened this issue Nov 12, 2019 · 0 comments · Fixed by #511
Closed

Copy to clipboard: Support for secondary button styling #76

ffriedl89 opened this issue Nov 12, 2019 · 0 comments · Fixed by #511
Assignees
@tomheller
Labels
feature has-pr P3 Important issue that needs to be resolved

Comments

@ffriedl89
Copy link
Collaborator

Expose button variant as part of the API since the copy action is not always the primary action.

We have a pattern where we describe that we should keep the amount of primary buttons to a minimum (preferably only one per page/card). We had a few use cases where the copy to clipboard component is used and the copy button is often not as important as other buttons on a page, that's why we had requests for a secondary button style for the copy to clipboard component. 

I think, it would suffice to just change the style of the button, as we're not using our button component in the copy to clipboard component. I'd keep the current functionality of the copy button as it is (turn into checkmark).

The secondary button should not replace the primary button, we need both versions (light+dark).
@ffriedl89 ffriedl89 added feature P2 Issue that is important to resolve as soon as possible labels Nov 12, 2019
@ffriedl89 ffriedl89 added P3 Important issue that needs to be resolved and removed P2 Issue that is important to resolve as soon as possible labels Dec 9, 2019
tomheller added a commit that referenced this issue Jan 31, 2020
@tomheller
feat(copy-to-clipboard): Added variant input to control embedded
528cf71 
button variant.

We have added an input to the copy-to-clipboard component that is passed
through to the button, which is being used in the copy to clipboard
template. The newly created input controls the variant of the embedded
button.

Fixes #76
@tomheller tomheller self-assigned this Jan 31, 2020
@tomheller tomheller mentioned this issue Jan 31, 2020
Merged
4 tasks
ffriedl89 pushed a commit that referenced this issue Jan 31, 2020
@tomheller @ffriedl89
feat(copy-to-clipboard): Added variant input to control embedded
0e83c14 
button variant.

We have added an input to the copy-to-clipboard component that is passed
through to the button, which is being used in the copy to clipboard
template. The newly created input controls the variant of the embedded
button.

Fixes #76
github-actions bot pushed a commit that referenced this issue Jan 31, 2020
@tomheller @ffriedl89
feat(copy-to-clipboard): Added variant input to control embedded
bbad528 
button variant.

We have added an input to the copy-to-clipboard component that is passed
through to the button, which is being used in the copy to clipboard
template. The newly created input controls the variant of the embedded
button.

Fixes #76
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@tomheller tomheller

Labels
feature has-pr P3 Important issue that needs to be resolved
Projects
None yet
Milestone
No milestone
2 participants
@ffriedl89 @tomheller