This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
fix(filter-field): Fixes an issue with validation flickering on free text. #1253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
target: minor
lukasholzer
approved these changes
Jul 13, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Fixes the issue by initializing the hidden FormControl with an empty value instead of null. This in combination with a check for difference when writing the control value fixed the dirty checks of the validator and therefor the flickering.
I also quickly tried to add an e2e test to this one, but the flickering made it really unstable. I opted to not add an e2e test for this one.
Fixes #1180
Type of PR
Bugfix
Checklist