Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

chore: Formatted new files #129

Merged
merged 2 commits into from
Nov 19, 2019
Merged

chore: Formatted new files #129

merged 2 commits into from
Nov 19, 2019

Conversation

thomaspink
Copy link
Contributor

This fixes the files that for some reason have not been formatted in the last PR.

Follow up: #128

Copy link
Contributor

@lara-aigmueller lara-aigmueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, thx! so sorry, don't know why my changes have not been formatted in the first place... 😞

Copy link
Contributor

@lukasholzer lukasholzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lukasholzer
Copy link
Contributor

I think it closes #128

@@ -1,12 +1,18 @@
# Barista components and design system

[![CircleCI](https://circleci.com/gh/Dynatrace/barista/tree/master.svg?style=svg)](https://circleci.com/gh/Dynatrace/barista/tree/master)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this already work? Currently the image looks broken.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strange. When i open the link directly it works.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably csp problems when viewing in a pull request. The other once work, because they are proxied through some camo.githubusercontent domain...

@thomaspink thomaspink merged commit 1d8bca7 into master Nov 19, 2019
@thomaspink thomaspink deleted the chore-format-files branch November 19, 2019 08:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants