Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

fix(quick-filter): Use internal uid for the filter generation. #1662

Merged
merged 1 commit into from
Oct 1, 2020

Conversation

lukasholzer
Copy link
Contributor

This issue should be a further step to make the quick filter stable.

Fixes #1647
Fixes #1522

Pull Request


Hi, thank you for contributing to Barista with this pull request (PR).

To ensure a fast process and merging of your PR please make sure it fulfills the
coding standards and contribution guidelines.

  • A feature proposal has been provided, discussed and approved first.
  • There is a meaningful description of the issue in GitHub (Screenshots are
    often helpful).
  • If the PR introduces breaking-changes or deprecations it matches the following
    guidelines.
    • The commit message follows our commit guidelines.
    • Tests for the changes have been added (for bug fixes / features).
    • Docs have been added / updated (for bug fixes / features).

Please choose the type appropriate for the changes below:

Type of PR

Checklist

  • I have read the CONTRIBUTING doc and I follow the PR guidelines
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@github-actions
Copy link

Deploy preview for barista ready!

Built with commit a0c75e2

✅ Preview: https://barista-fzkhadoe6.vercel.app

This pull request is being automatically deployed with now-deployment

@lukasholzer lukasholzer force-pushed the fix/quick-filter-fix-data-handling branch from a0c75e2 to 597ea2c Compare September 25, 2020 11:14
@github-actions
Copy link

Deploy preview for barista ready!

Built with commit 597ea2c

✅ Preview: https://barista-d3we047p8.vercel.app

This pull request is being automatically deployed with now-deployment

@lukasholzer lukasholzer force-pushed the fix/quick-filter-fix-data-handling branch from 597ea2c to 3923f79 Compare September 28, 2020 07:21
@github-actions
Copy link

Deploy preview for barista ready!

Built with commit 3923f79

✅ Preview: https://barista-axoh24hsa.vercel.app

This pull request is being automatically deployed with now-deployment

@lukasholzer lukasholzer force-pushed the fix/quick-filter-fix-data-handling branch from 3923f79 to 8af759c Compare September 28, 2020 07:47
@github-actions
Copy link

Deploy preview for barista ready!

Built with commit 8af759c

✅ Preview: https://barista-nhpe9qq4o.vercel.app

This pull request is being automatically deployed with now-deployment

@lukasholzer lukasholzer force-pushed the fix/quick-filter-fix-data-handling branch from 8af759c to 5d0aab1 Compare September 29, 2020 07:36
@github-actions
Copy link

Deploy preview for barista ready!

Built with commit 5d0aab1

✅ Preview: https://barista-icurcvg3t.vercel.app

This pull request is being automatically deployed with now-deployment

This issue should be a further step to make the quick filter stable.

Fixes #1647
Fixes #1522
@github-actions
Copy link

Deploy preview for barista ready!

Built with commit 9139f72

✅ Preview: https://barista-9vohftvr5.vercel.app

This pull request is being automatically deployed with now-deployment

@lukasholzer lukasholzer added the pr: merge-ready This PR is ready to be merged label Oct 1, 2020
@github-actions github-actions bot added target: minor This PR is targeted for the next minor release target: patch This PR is targeted for the next patch release labels Oct 1, 2020
@lukasholzer lukasholzer merged commit 551ef8d into master Oct 1, 2020
@lukasholzer lukasholzer deleted the fix/quick-filter-fix-data-handling branch October 1, 2020 06:14
@github-actions
Copy link

github-actions bot commented Oct 1, 2020

The auto cherry picker succeeded.Cherry picked to minor branch 8.x. New head is now eafc15c
Cherry picked to patch branch 8.0.x. New head is now a6a999e

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr: merge-ready This PR is ready to be merged target: minor This PR is targeted for the next minor release target: patch This PR is targeted for the next patch release
Projects
None yet
4 participants