This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
feat(icon): Retry loading hiccup resources. #2172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- internal issue: APM-310496 APM-282779 - nowadays CDNs are distributed systems that does not guarantees your request to reach right place. It started happening few hounders times per day for us that some icon couldn't be loaded - CloudFront explicitly marks that requests *needs* to be retried - mechanism is fairly simple, we retry any error from the server side (AWS throws 500 / 504 / 503 / 403) - 3 retries is enough for other resources we already handle - docs: https://www.learnrxjs.io/learn-rxjs/operators/error_handling/retry
|
|
rowa-audil
added
pr: merge-ready
piotrl
added a commit
to piotrl/barista
that referenced
this pull request
Sep 23, 2021
* Previous fix PR dynatrace-oss#2172 improved spam a lot, we have now instead 500 logs daily, only 1-2 * But still we have them daily, preferrably we'd like to not see it again as a hiccup ;) * Suggestion: Keep severity as INFO instead WARN
thomaspink
pushed a commit
that referenced
this pull request
Sep 23, 2021
* Previous fix PR #2172 improved spam a lot, we have now instead 500 logs daily, only 1-2 * But still we have them daily, preferrably we'd like to not see it again as a hiccup ;) * Suggestion: Keep severity as INFO instead WARN
thomaspink
pushed a commit
that referenced
this pull request
Sep 23, 2021
* Previous fix PR #2172 improved spam a lot, we have now instead 500 logs daily, only 1-2 * But still we have them daily, preferrably we'd like to not see it again as a hiccup ;) * Suggestion: Keep severity as INFO instead WARN
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR
Feature (non-breaking change which adds functionality)
Checklist