-
Notifications
You must be signed in to change notification settings - Fork 78
fix: Timestamp/range being re-opened on window resize. #432
fix: Timestamp/range being re-opened on window resize. #432
Conversation
@peter-affenzeller Our cirlceci trial has run out, which is why we cannot run builds on xlarge resources any more. Could you update your branch from the |
62aa65d
to
6c2c268
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please Provide an issue for what you want to accomplish with this pr (maybe with a short video about the not working behaviour).
Regarding the changes you made in the components/chart/src/selection-area/selection-area.ts
it is not clear for me what you want to accomplish with that. What you have written cannot work.
Please provide an explanation of the stream changes from line 803 to 873 in psudo code.
Explain what does not work out currently where you see the problem and what would your approach on fixing this behaviour.
apps/components-e2e/src/components/chart/selection-area/selection-area.e2e.ts
Outdated
Show resolved
Hide resolved
apps/components-e2e/src/components/chart/selection-area/selection-area.e2e.ts
Show resolved
Hide resolved
As @lukasholzer said, please provide either a description in the PR or an issue. |
6c2c268
to
031272e
Compare
@peter-affenzeller please rebase with current master and resolve conflicts for further reviewing |
c4fcc34
to
709b5fe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small minor changes to reduce the flaky e2e tests that you have written.
And please add one more scenario like described in the connected issue #96.
After you have done those changes please rebase and reword your commit message that it meets our contribution guidelines.
You should provide the scope you are working fix(chart): ...
to the message start and add the issue in the bottom description.
For example:
fix:(chart): Fixes an issue where the chart selection was re-opened on window resize.
Provide a more detailed description.
Fixes #{issue-number}
Sorry for the tedious commit/rebase madness but we need proper commit messages to generate our changelog out of it. So that people understand what we have fixed with this commit.
@@ -456,6 +457,11 @@ export class DtChartSelectionArea implements AfterContentInit, OnDestroy { | |||
|
|||
/** If there is an overlay open it will dispose it and destroy it */ | |||
private _closeOverlay(): void { | |||
// remove class showing the arrows of the range handles | |||
if (this._chart._range) { | |||
this._chart._range._reflectRangeReleased(false); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@peter-affenzeller I tried to finish your PR as requested, but when I removed this part of the code, the test failed. Did you figure out, why this is needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lukasholzer @tomheller this is intended to remove the class that makes the little arrows of the drag handles fade in so that they fade in every time the range is opened (also with keyboard input. currently, when you focus the chart and convert a timestamp to a range they don't show), in combination with the reflectRangeReleased(true) in line 334. but I just checked again, this also seems to not work properly, probably better to do this in another PR.
apps/components-e2e/src/components/chart/selection-area/selection-area.e2e.ts
Show resolved
Hide resolved
apps/components-e2e/src/components/chart/selection-area/selection-area.e2e.ts
Show resolved
Hide resolved
apps/components-e2e/src/components/chart/selection-area/selection-area.e2e.ts
Show resolved
Hide resolved
apps/components-e2e/src/components/chart/selection-area/selection-area.e2e.ts
Show resolved
Hide resolved
apps/components-e2e/src/components/chart/selection-area/selection-area.e2e.ts
Outdated
Show resolved
Hide resolved
apps/components-e2e/src/components/chart/selection-area/selection-area.e2e.ts
Show resolved
Hide resolved
apps/components-e2e/src/components/chart/selection-area/selection-area.e2e.ts
Outdated
Show resolved
Hide resolved
10e8e86
to
8449adc
Compare
@lukasholzer The flaky end2end test should be solved, when #610 is merged and rebased, as this deals with the update of the overlay, when change detection runs. |
8449adc
to
a542bac
Compare
resizing the window. When closing a timestamp or range and then resizing the window, the overlay is re-opened. This PR fixes that issue by splitting up the stream that fires when a timestamp/range changes and the window resize stream and only updating the overlay on resize if it actually exists. Fixes dynatrace-oss#472
a542bac
to
00afb28
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great Work! @tomheller thanks for finishing this 🐳
Pull request commit |
Pull Request
Hi, thank you for contributing to Barista with this pull request (PR).
To ensure a fast process and merging of your PR please make sure it fulfills the
coding standards and contribution guidelines.
often helpful).
guidelines.
Please choose the type appropriate for the changes below:
Type of PR
Bugfix (non-breaking change which fixes an issue)
Checklist