fix: Timestamp/range being re-opened on window resize.

[peter-affenzeller]

Pull Request

---

Hi, thank you for contributing to Barista with this pull request (PR).

To ensure a fast process and merging of your PR please make sure it fulfills the
coding standards and contribution guidelines.

• A feature proposal has been provided, discussed and approved first.
• There is a meaningful description of the issue in GitHub (Screenshots are
  often helpful).
• If the PR introduces breaking-changes or deprecations it matches the following
  guidelines.
  • The commit message follows our commit guidelines.
  • Tests for the changes have been added (for bug fixes / features).
  • Docs have been added / updated (for bug fixes / features).

Please choose the type appropriate for the changes below:

Type of PR

Bugfix (non-breaking change which fixes an issue)

Checklist

• I have read the CONTRIBUTING doc and I follow the PR guidelines
• Lint and unit tests pass locally with my changes
• I have added tests that prove my fix is effective or that my feature works
• I have added necessary documentation (if appropriate)

[tomheller]

@peter-affenzeller Our cirlceci trial has run out, which is why we cannot run builds on xlarge resources any more. Could you update your branch from the dynatrace-oss/barista:master to get the fix for this problem?

[lukasholzer]

Please Provide an issue for what you want to accomplish with this pr (maybe with a short video about the not working behaviour).

Regarding the changes you made in the components/chart/src/selection-area/selection-area.ts it is not clear for me what you want to accomplish with that. What you have written cannot work.

Please provide an explanation of the stream changes from line 803 to 873 in psudo code.
Explain what does not work out currently where you see the problem and what would your approach on fixing this behaviour.

[thomaspink]

As @lukasholzer said, please provide either a description in the PR or an issue.

[lukasholzer]

@peter-affenzeller please rebase with current master and resolve conflicts for further reviewing

[lukasholzer]

Small minor changes to reduce the flaky e2e tests that you have written.

And please add one more scenario like described in the connected issue #96.

After you have done those changes please rebase and reword your commit message that it meets our contribution guidelines.

You should provide the scope you are working fix(chart): ... to the message start and add the issue in the bottom description.

For example:

fix:(chart): Fixes an issue where the chart selection was re-opened on window resize.

Provide a more detailed description.
Fixes #{issue-number}

Sorry for the tedious commit/rebase madness but we need proper commit messages to generate our changelog out of it. So that people understand what we have fixed with this commit.

[lukasholzer]

why is this needed?

[tomheller]

@peter-affenzeller I tried to finish your PR as requested, but when I removed this part of the code, the test failed. Did you figure out, why this is needed?

[peter-affenzeller]

@lukasholzer @tomheller this is intended to remove the class that makes the little arrows of the drag handles fade in so that they fade in every time the range is opened (also with keyboard input. currently, when you focus the chart and convert a timestamp to a range they don't show), in combination with the reflectRangeReleased(true) in line 334. but I just checked again, this also seems to not work properly, probably better to do this in another PR.

[tomheller]

@lukasholzer The flaky end2end test should be solved, when #610 is merged and rebased, as this deals with the update of the overlay, when change detection runs.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities (and 2 Security Hotspots to review)
0 Code Smells

0.0% Coverage
0.0% Duplication

[lukasholzer]

Great Work! @tomheller thanks for finishing this 🐳

[tomheller]

Pull request commit 732cb40b914854890575fceb8e878a3d32c24f66 has been cherry picked to 5.x and 5.2.x